Details
- Reviewers
dch - Commits
- R11:783a09e70f23: devel/buildkite_agent: Enable logfile for output
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
- needs a PORTREVISION bump
- what happens in the default case where buildkit_logfile is not set?
Oh ok. I will bump before pushed. Thanks!
- what happens in the default case where buildkit_logfile is not set?
buildkite_logfile:=/var/log/buildkite.log
Wouldn't mean it is /var/log/buildkite.log by default?
Sigh, it's already set in L28... but if the file isn't present, it needs to be created with correct permissions, otherwise it won't be set. Can you add that please?
My understanding is that /usr/sbin/daemon will automatically create the file with correct permission as its permission is decided by buildkite_account and can be changed later.
I also check some other ports that set the logfile and they also don't ship the file in plist or create the logfile.
By default this is the permissions the log file is created with:
-rw------- 1 root wheel 153B Jul 13 23:35 buildkite.log
If this is what you intend to happen then let's commit this as is. If you're expecting it to be created readable by buildkite_account then it would need changing to have a precmd script.
I just check the daemon implementation. It pipe the file from parent to the child. So root access is fine. And allowing only root to access the log from daemon only instead of the running user is also our convention I think.