libcxxrt: Fix diagnostics for derived classes
ClosedPublic
Actions

Authored by emaste on Wed, Jun 24, 3:23 PM.

Details

Reviewers

theraven
dim

Commits

rG3a5c2899fc7b: libcxxrt: Fix diagnostics for derived classes

Summary

In terminate_with_diagnostics the cast_to arguments were swapped, so it
always failed.  The diagnostic handler produced output like "Terminating
due to uncaught exception 0x24891e08000 of type std::runtime_error".
Now e->what() will actually be included in the output, e.g. "Terminating
due to uncaught exception 0x2bba49208000 'Model file doesn't exist' of
type std::runtime_error".

Event:          Halifax Hackathon 202606
Sponsored by:   The FreeBSD Foundation

Also to be upstreamed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Wed, Jun 24, 3:23 PM

emaste created this revision.

Hm, I remember something similar occurring when I was attempting to debug that std::ios ABI issue. This would also throw some exceptions during initialization, and it resulted in strange messages from libcxxrt. I didn't have the time then to investigate, but it could very well have been this issue.!

This revision is now accepted and ready to land.Wed, Jun 24, 5:01 PM

Closed by commit rG3a5c2899fc7b: libcxxrt: Fix diagnostics for derived classes (authored by emaste). · Explain WhyWed, Jun 24, 5:36 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG3a5c2899fc7b: libcxxrt: Fix diagnostics for derived classes.

Herald added a subscriber: imp. · View Herald TranscriptWed, Jun 24, 5:36 PM

Please can you submit this upstream as well?