hym8563: Fix 32-bit powerpc build
ClosedPublic
Actions

Authored by jhibbits on Wed, Jun 24, 2:40 AM.

Details

Reviewers

Commits

rGa8566c71ce46: hym8563: Fix 32-bit powerpc build

Summary

Depend on clknode_if.h in the module Makefile, so that it gets
explicitly built for the module. Also, reduce the #if guards to only
the new clock output code, and gate them on all powerpc, not just
powerpc64.

Fixes: 6b77d34f("HYM8563: Add support for clock output.")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Wed, Jun 24, 2:40 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jun 24, 2:40 AM

jhibbits requested review of this revision.Wed, Jun 24, 2:40 AM

Harbormaster completed remote builds in B74175: Diff 180489.Wed, Jun 24, 2:40 AM

jhibbits added a reviewer: mmel.Wed, Jun 24, 2:41 AM

I would much rather have PowerPC adapt the clock, reset and other frameworks. After all, PowerPC .dts files use them, so I don't see a single reason why we could not include them in the PowerPC build.
The assumption that FDT means that all these frameworks would make the world much simpler.

This revision is now accepted and ready to land.Wed, Jun 24, 11:20 AM

Closed by commit rGa8566c71ce46: hym8563: Fix 32-bit powerpc build (authored by jhibbits). · Explain WhyWed, Jul 1, 2:42 AM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rGa8566c71ce46: hym8563: Fix 32-bit powerpc build.