Paths

Table of Contentst

Differential D57781

fusefs: fix a race in the pre-init tests
ClosedPublic
Actions

Authored by asomers on Tue, Jun 23, 5:15 PM.

Tags

None

Referenced Files

	F162638567: D57781.diff
	Wed, Jul 15, 7:27 AM

	F162638566: D57781.diff
	Wed, Jul 15, 7:27 AM

	F162567927: D57781.diff
	Tue, Jul 14, 3:25 PM

	Unknown Object (File)
	Mon, Jul 6, 1:37 AM

	Unknown Object (File)
	Sun, Jul 5, 9:23 PM

	Unknown Object (File)
	Sun, Jul 5, 9:20 PM

	Unknown Object (File)
	Sun, Jul 5, 7:14 PM

	Unknown Object (File)
	Sun, Jul 5, 7:11 PM

View All 23 Files

Subscribers

Details

Reviewers

Commits

rGc57b054c9e7d: fusefs: fix a race in the pre-init tests
rG2c1482e30536: fusefs: fix a race in the pre-init tests

Summary

These tests allow the user to customize the INIT response. But it's
necessary to block the daemon's service loop from running until those
expectations have been set. This race has never caused failures before
simply due to luck. But now it's failing on slower platforms.

PR: 296236
Reported by: siva
MFC after: 2 weeks
Sponsored by: ConnectWise

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Tue, Jun 23, 5:15 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 23, 5:15 PM

asomers requested review of this revision.Tue, Jun 23, 5:15 PM

Harbormaster completed remote builds in B74160: Diff 180436.Tue, Jun 23, 5:15 PM

LGTM, passes 200+ consecutive runs on riscv64 QEMU.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jun 23, 6:02 PM

Closed by commit rG2c1482e30536: fusefs: fix a race in the pre-init tests (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG2c1482e30536: fusefs: fix a race in the pre-init tests.

otis added a subscriber: otis.Tue, Jun 23, 8:25 PM

otis added inline comments.

tests/sys/fs/fusefs/mockfs.cc
1023	A bit belated proof-reading: Redundant `Couldn't`.

asomers added inline comments.Tue, Jun 23, 8:50 PM

tests/sys/fs/fusefs/mockfs.cc
1023	Good catch. Fixed by 381ebe25f0b9 .

asomers added a commit: rGc57b054c9e7d: fusefs: fix a race in the pre-init tests.Wed, Jul 8, 5:58 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

fs/

fusefs/

3 lines

11 lines

6 lines

Diff 180437

tests/sys/fs/fusefs/mockfs.hh

Loading...

tests/sys/fs/fusefs/mockfs.cc

Loading...

tests/sys/fs/fusefs/pre-init.cc

Loading...