firewire: clean up XXX comments
ClosedPublic
Actions

Authored by guest-seuros on Fri, Jun 5, 10:10 AM.

Details

Reviewers

imp
adrian

Commits

rG4a299ef19c7e: firewire: clean up XXX comments

Summary

Remove stale and misleading XXX comments throughout firewire.c.
Most were from the original 2002 codebase and either described
correct behavior or noted aspirational improvements that never
happended.

Two actionable items retained as TODO: config ROM CRC validation
and pending xfer cleanup on detach.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-seuros requested review of this revision.Fri, Jun 5, 10:10 AM

guest-seuros created this revision.

Harbormaster completed remote builds in B73700: Diff 179266.Fri, Jun 5, 10:10 AM

adrian added inline comments.Fri, Jun 5, 11:18 PM

sys/dev/firewire/firewire.c
2196	why'd you remove this? does this already work for 64 bit nowdays?

guest-seuros marked an inline comment as done.Fri, Jun 5, 11:32 PM

guest-seuros added inline comments.

sys/dev/firewire/firewire.c
2196	Because it working. (i tried it on AMD64 only) I want to extract the this block code to debug.c (but that could be another diff).

imp added inline comments.Sat, Jun 6, 2:51 AM

sys/dev/firewire/firewire.c
691	The 0x0083c0 was /* xxx */'d here. Maybe it's still relevent.

guest-seuros marked 2 inline comments as done.Sat, Jun 6, 7:04 AM

guest-seuros added inline comments.

sys/dev/firewire/firewire.c
691	This link-layer capability flags, every OS use this magic number unless the driver is lacking capabilities. I will follow with more refactoring once this is accepted/land . 0x0083c0 will go to constant and i will reference the IEEE 1394 pdf (if someone want to dig into it). I just avoiding to have a big diff with mutation and cleaning