Differential D56568

ctl: require ctladm in addition to sg_opcodes
ClosedPublic
Actions

Authored by olivier on Wed, Apr 22, 7:48 AM.

Details

Reviewers

asomers

Group Reviewers

cam

Commits

rG19213b8eb33f: ctl: require ctladm in addition to sg_opcodes

Summary

Each test case in opcodes.sh uses ctladm to create and remove the LUN it exercises, but only sg_opcodes was listed in require.progs. On systems where ctladm is not builded the tests would fail at setup instead of being skipped cleanly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier created this revision.Wed, Apr 22, 7:48 AM

Herald added a reviewer: cam. · View Herald TranscriptWed, Apr 22, 7:48 AM

olivier requested review of this revision.Wed, Apr 22, 7:48 AM

olivier added a reviewer: asomers.

Good catch.

This revision is now accepted and ready to land.Wed, Apr 22, 12:47 PM

Closed by commit rG19213b8eb33f: ctl: require ctladm in addition to sg_opcodes (authored by olivier). · Explain WhyWed, Apr 22, 2:17 PM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rG19213b8eb33f: ctl: require ctladm in addition to sg_opcodes.

Herald added a subscriber: imp. · View Herald TranscriptWed, Apr 22, 2:17 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

cam/

ctl/

opcodes.sh

18 lines

Diff 176112

View Options

tests/sys/cam/ctl/opcodes.sh

ctl: require ctladm in addition to sg_opcodesClosedPublicActions