[BHND] Fix typo in name of bhnd_bus_deactivate_resource dev method and cross-compilation (plus bootverbose information)

[mizhka]

Summary

This patch is intended to fix typo in name of bhnd_bus_deactivate_resource dev method and cross-compilation (plus bootverbose information).

Disclaimer: it's my first experience of work with phabricator :)

[adrian]

other than that, lgtm

sys/dev/bhnd/bcma/bcma.c

302

spacing

311

spacing

sys/dev/bhnd/bhnd_subr.c

187

use ()'s, like the rest of the returns above!

595

• spacing
• you don't need to use { }s for a single line device_printf()

600

spacing, parens.

[mizhka]

@adrian, corrected.

[landon_landonf.org]

Requested changes inline as source comments; sorry for the delay, I accidentally left my comments unsubmitted (I'm new to phabricator too).

sys/dev/bhnd/bcma/bcma.c

254

Since the BHND_PORT_* values are a typedef'd enum, leaving out the default case allows the compiler to give us a warning if we add an additional BHND_PORT type and fail to update this switch()

302

Since this is likely only useful during platform bring-up, I'd suggest conditionalizing this on a debug tunable, similar to 'bhndb_debug' used in bhndb.

sys/dev/bhnd/bcma/bcma_subr.c

138

Since this function isn't defined as returning NULL, this should either be a __unreachable() or should be omitted.

(The only way that NULL can be returned is if a new BHND_PORT_* enum value is added without updating this switch() statement)

sys/dev/bhnd/bhnd_subr.c

186

Same BHND_PORT_* default switch statement issue. I'll stop noting cases after this one.

584

These RID allocation debugging statements should either be removed, or centralized in the bhnd bus_* resource handling functions.

The other bring-up debugging statements below (e.g. CHIPC pre-read) should probably be removed entirely before integration; I'll stop noting them after this point.