Page MenuHomeFreeBSD
Differential D56309

amd64: Make EFI runtime faults less like panics
ClosedPublic
Actions

Authored by emaste on Apr 8 2026, 2:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 6:22 AM
Unknown Object (File)
Mon, May 18, 6:18 AM
Unknown Object (File)
Sun, May 17, 8:14 AM
Unknown Object (File)
Sun, May 17, 1:51 AM
Unknown Object (File)
Fri, May 15, 10:57 AM
Unknown Object (File)
Thu, May 14, 3:44 PM
Unknown Object (File)
Thu, May 14, 1:36 PM
Unknown Object (File)
Thu, May 14, 1:22 PM
View All 35 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rGddabf7f3ea4f: amd64: Make EFI runtime faults look less like panics
Summary

EFI runtime faults may be mistaken for kernel panics or actual problems. Try to make it a little more clear.

I wrote this patch a while back and then forgot about it. Was reminded by recent PRs e.g. 287422 and 294292.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Apr 8 2026, 2:11 PM
emaste updated this revision to Diff 175126.
emaste created this revision.

tidy up

kib accepted this revision.Apr 8 2026, 2:37 PM
kib added inline comments.
sys/amd64/amd64/trap.c
241

I do not think we need same two newliines before the start of printing as for the panicing report, but at least a single new line is useful IMO, since we could interrupt some other printout on the console.

This revision is now accepted and ready to land.Apr 8 2026, 2:37 PM
emaste updated this revision to Diff 176731.Tue, Apr 28, 2:54 PM

One newline for EFI faults

This revision now requires review to proceed.Tue, Apr 28, 2:54 PM
emaste marked an inline comment as done.Tue, Apr 28, 2:55 PM
emaste added inline comments.
sys/amd64/amd64/trap.c
241

Yes good point. I went back to one \n "built in" to trap_diag and one extra in the string in trap_fatal.

kib accepted this revision.Tue, Apr 28, 2:58 PM
This revision is now accepted and ready to land.Tue, Apr 28, 2:58 PM
Closed by commit rGddabf7f3ea4f: amd64: Make EFI runtime faults look less like panics (authored by emaste). · Explain WhyTue, Apr 28, 3:14 PM
This revision was automatically updated to reflect the committed changes.
emaste marked an inline comment as done.
emaste added a commit: rGddabf7f3ea4f: amd64: Make EFI runtime faults look less like panics.
Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 28, 3:14 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
10 lines

Diff 176732

View Options

sys/amd64/amd64/trap.c

Loading...