Page MenuHomeFreeBSD
Differential D56309

amd64: Make EFI runtime faults less like panics
AcceptedPublic
Actions

Authored by emaste on Wed, Apr 8, 2:11 PM.
Tags
None
Referenced Files
F152968530: D56309.id175124.diff
Sat, Apr 18, 9:41 AM
F152968486: D56309.id175126.diff
Sat, Apr 18, 9:41 AM
F152956182: D56309.diff
Sat, Apr 18, 7:49 AM
F152956175: D56309.diff
Sat, Apr 18, 7:49 AM
F152956127: D56309.diff
Sat, Apr 18, 7:48 AM
Unknown Object (File)
Thu, Apr 16, 6:56 AM
Unknown Object (File)
Tue, Apr 14, 10:28 AM
Unknown Object (File)
Mon, Apr 13, 2:20 PM
Subscribers
None

Details

Reviewers
kib
Summary

EFI runtime faults may be mistaken for kernel panics or actual problems. Try to make it a little more clear.

I wrote this patch a while back and then forgot about it. Was reminded by recent PRs e.g. 287422 and 294292.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Wed, Apr 8, 2:11 PM
emaste updated this revision to Diff 175126.
emaste created this revision.

tidy up

kib accepted this revision.Wed, Apr 8, 2:37 PM
kib added inline comments.
sys/amd64/amd64/trap.c
241

I do not think we need same two newliines before the start of printing as for the panicing report, but at least a single new line is useful IMO, since we could interrupt some other printout on the console.

This revision is now accepted and ready to land.Wed, Apr 8, 2:37 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
10 lines

Diff 175126

View Options

sys/amd64/amd64/trap.c

Loading...