Page MenuHomeFreeBSD
Differential D56097

uart/pci: always disable MSI for generic devices
ClosedPublic
Actions

Authored by royger on Thu, Mar 26, 8:26 PM.
Tags
None
Referenced Files
F150776233: D56097.diff
Fri, Apr 3, 11:51 PM
Unknown Object (File)
Tue, Mar 31, 10:02 PM
Unknown Object (File)
Mon, Mar 30, 3:32 PM
Unknown Object (File)
Mon, Mar 30, 5:32 AM
Unknown Object (File)
Mon, Mar 30, 4:40 AM
Unknown Object (File)
Fri, Mar 27, 12:58 AM
Subscribers
None

Details

Reviewers
marcel
imp
Commits
rGc562c81e315c: uart/pci: always disable MSI for generic devices
Summary

The generic device pci_id structure in uart_pci_probe() already has
PCI_NO_MSI appended to it's flags, however that information is not
propagated into uart_pci_attach().

Assume that any device that doesn't match the known IDs is a generic UART
device, and hence prevent the usage of MSIs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

royger requested review of this revision.Thu, Mar 26, 8:26 PM
royger created this revision.
imp accepted this revision.Fri, Mar 27, 3:24 AM
This revision is now accepted and ready to land.Fri, Mar 27, 3:24 AM
Closed by commit rGc562c81e315c: uart/pci: always disable MSI for generic devices (authored by royger). · Explain WhyFri, Mar 27, 8:34 AM
This revision was automatically updated to reflect the committed changes.
royger added a commit: rGc562c81e315c: uart/pci: always disable MSI for generic devices.

Revision Contents
Changeset List

PathSize
sys/
dev/
uart/
3 lines

Diff 174372

View Options

sys/dev/uart/uart_bus_pci.c

Loading...