Page MenuHomeFreeBSD
Differential D5579

Update to 0.1.7, add DOCS and NLS options
ClosedPublic
Actions

Authored by olivier on Mar 8 2016, 10:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 29, 6:18 AM
Unknown Object (File)
Thu, Sep 26, 8:42 AM
Unknown Object (File)
Mon, Sep 23, 5:11 PM
Unknown Object (File)
Sun, Sep 22, 4:13 PM
Unknown Object (File)
Sat, Sep 21, 11:09 PM
Unknown Object (File)
Fri, Sep 20, 11:43 PM
Unknown Object (File)
Fri, Sep 20, 5:33 AM
Unknown Object (File)
Thu, Sep 19, 4:03 AM
View All 77 Files
Subscribers
mat

Details

Reviewers
tabthorpe
jadawin
Commits
rP410617: Update to 0.1.7, add DOCS and NLS options

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2818
Build 2842: arc lint + arc unit

Event Timeline

olivier updated this revision to Diff 14160.Mar 8 2016, 10:34 AM
olivier retitled this revision from to Update to 0.1.7, add DOCS and NLS options.
olivier updated this object.
olivier edited the test plan for this revision. (Show Details)
olivier added reviewers: jadawin, tabthorpe.
Herald added a subscriber: mat. · View Herald TranscriptMar 8 2016, 10:34 AM
mat added inline comments.Mar 8 2016, 10:44 AM
mail/deforaos-mailer/Makefile
37

This needs to be after bsd.port.pre.mk, I think. It could also always be there, as it works for both cases.

jadawin added inline comments.Mar 8 2016, 10:55 AM
mail/deforaos-mailer/Makefile
37

I confirm. I strongly suggest to use:

.include <bsd.port.pre.mk>
[...]
.if defined(WITH_OPENSSL_BASE)
.endif
[...]
.include <bsd.port.post.mk>

And I suggest to mat to wait at least for a reviewer's reaction before commenting so fast.

olivier updated this revision to Diff 14166.Mar 8 2016, 2:10 PM

Fix "if defined" in Makefile as instructed by my venerate official and unofficial mentors :-)
Poudriere testport log files:

jadawin accepted this revision.Mar 8 2016, 2:30 PM
jadawin edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2016, 2:30 PM
Closed by commit rP410617: Update to 0.1.7, add DOCS and NLS options (authored by olivier). · Explain WhyMar 8 2016, 2:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mail/
deforaos-mailer/
48 lines
4 lines
files/
13 lines
8 lines

Diff 14166

View Options

mail/deforaos-mailer/Makefile

Loading...
View Options

mail/deforaos-mailer/distinfo

Loading...
View Options

mail/deforaos-mailer/files/patch-doc_Makefile

Loading...
View Options

mail/deforaos-mailer/files/patch-doc__Makefile

Loading...
View Options

mail/deforaos-mailer/pkg-plist

Loading...