Page MenuHomeFreeBSD

cad/electric-ng: Update 9.07 => 9.08.1, refactor, take maintainership
Needs ReviewPublic

Authored by alven on Sun, Mar 8, 8:07 PM.

Details

Reviewers
db
yuri
arrowd
vvd
Summary
  • Rewrite the port to clean modern standards with many improvements
Test Plan

For every {150amd64, 143amd64}:

  • Successful poudriere testport
  • Successful run-testing

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 71275
Build 68158: arc lint + arc unit

Event Timeline

alven requested review of this revision.Sun, Mar 8, 8:07 PM
alven created this revision.
cad/electric-ng/Makefile
17–18

Where is unzip in base: /usr/bin/unzip.
Try to use ${UNZIP_NATIVE_CMD} instead of ${UNZIP_CMD}.

18

Did you tested runtime with OpenJDK 25 with option 3D enabled (rquire java/java3d - supports OpenJDK 8 only)?

26

PLIST_SUB+= VERSION="${DISTVERSION:R}"

28–49
BSH_VARS=	LIBFILES+=${JAVALIBDIR}/bsh.jar
PLUGINS_VARS=	LIBFILES+=${PREFIX}/libexec/${PORTNAME}${PKGNAMESUFFIX}/${SFS_JARFILE}
cad/electric-ng/pkg-plist
2–5

And use %%VERSION%% here.

Thank you! :) I'll try to address all the issues you've mentioned and learn from you :)

Address almost all the issues mentioned on review

alven marked an inline comment as done.Mon, Mar 9, 6:09 AM
alven added inline comments.
cad/electric-ng/Makefile
18

java/java3d - supports OpenJDK 8 only?

Yes, this exactly [0].
And this is the latest and only version around [1].

May I as a future maintainer just drop support for this option (and PLUGINS also, as it depends on java/jmf, which has very restrictive license)?

[0] https://cgit.freebsd.org/ports/tree/java/java3d/Makefile#n19
[1] https://repology.org/project/java3d/versions
[2] https://www.freshports.org/java/jmf

alven marked an inline comment as done.Mon, Mar 9, 6:14 AM
alven added inline comments.
cad/electric-ng/Makefile
18

P.S. Plugins' supporting code is likely non-free by itself [0, 1]. I would be happy to get rid of it!

[0] https://www.staticfreesoft.com/productsFree.html
[1] https://www.staticfreesoft.com/jmanual/mchap01-05.html