Page MenuHomeFreeBSD
Differential D55668

amd64: Make start_all_aps() static
ClosedPublic
Actions

Authored by zlei on Mar 5 2026, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 17, 7:39 PM
Unknown Object (File)
Thu, Sep 3, 8:31 PM
Unknown Object (File)
Thu, Sep 3, 5:04 AM
Unknown Object (File)
Tue, Sep 1, 4:54 PM
Unknown Object (File)
Tue, Sep 1, 3:10 AM
Unknown Object (File)
Sun, Aug 30, 3:06 PM
Unknown Object (File)
Sat, Aug 29, 4:38 PM
Unknown Object (File)
Thu, Aug 27, 2:16 AM
View All 67 Files
Subscribers
imp

Details

Reviewers
royger
Commits
rGfa5f0d95be25: amd64: Make start_all_aps() static
rGf521487cd935: amd64: Make start_all_aps() static
rG5f0ab9d9e965: amd64: Make start_all_aps() static
Summary

It is not used elsewhere since the change [1].

[1] ac3ede5371af x86/xen: remove PVHv1 code

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Mar 5 2026, 2:54 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 5 2026, 2:54 PM
zlei requested review of this revision.Mar 5 2026, 2:54 PM
zlei added a comment.Mar 5 2026, 2:57 PM

I'm almost certainly that leaving start_all_aps() public visible was unintended. Post to review for sure.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2026, 4:26 AM
Closed by commit rG5f0ab9d9e965: amd64: Make start_all_aps() static (authored by zlei). · Explain Why
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG5f0ab9d9e965: amd64: Make start_all_aps() static.
zlei added a commit: rGf521487cd935: amd64: Make start_all_aps() static.Mar 20 2026, 10:01 AM
zlei added a commit: rGfa5f0d95be25: amd64: Make start_all_aps() static.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
3 lines
include/
1 line

Diff 173599

View Options

sys/amd64/amd64/mp_machdep.c

Loading...
View Options

sys/amd64/include/smp.h

Loading...