Paths

Table of Contentst

amd64: Make start_all_aps() static
ClosedPublic
Actions

Authored by zlei on Mar 5 2026, 2:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 31, 8:23 AM

	Unknown Object (File)
	Sun, Mar 29, 1:22 AM

	Unknown Object (File)
	Tue, Mar 24, 3:59 PM

	Unknown Object (File)
	Sun, Mar 22, 1:47 PM

	Unknown Object (File)
	Sun, Mar 22, 12:14 PM

	Unknown Object (File)
	Sun, Mar 15, 8:00 PM

	Unknown Object (File)
	Thu, Mar 12, 9:02 AM

	Unknown Object (File)
	Thu, Mar 12, 5:15 AM

View All 13 Files

Subscribers

imp

Details

Reviewers

royger

Commits

rGfa5f0d95be25: amd64: Make start_all_aps() static
rGf521487cd935: amd64: Make start_all_aps() static
rG5f0ab9d9e965: amd64: Make start_all_aps() static

Summary

It is not used elsewhere since the change [1].

[1] ac3ede5371af x86/xen: remove PVHv1 code

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Mar 5 2026, 2:54 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 5 2026, 2:54 PM

zlei requested review of this revision.Mar 5 2026, 2:54 PM

I'm almost certainly that leaving start_all_aps() public visible was unintended. Post to review for sure.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Mar 12, 4:26 AM

Closed by commit rG5f0ab9d9e965: amd64: Make start_all_aps() static (authored by zlei). · Explain Why

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG5f0ab9d9e965: amd64: Make start_all_aps() static.

zlei added a commit: rGf521487cd935: amd64: Make start_all_aps() static.Fri, Mar 20, 10:01 AM

zlei added a commit: rGfa5f0d95be25: amd64: Make start_all_aps() static.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

mp_machdep.c

3 lines

include/

smp.h

1 line

Diff 173599

View Options

sys/amd64/amd64/mp_machdep.c