Page MenuHomeFreeBSD

shells/mksh: Fix MASTER_SITES
ClosedPublic

Authored by nxjoseph on Thu, Feb 26, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 12, 8:21 PM
Unknown Object (File)
Mon, Mar 2, 10:25 PM
Unknown Object (File)
Mon, Mar 2, 7:38 PM
Unknown Object (File)
Sun, Mar 1, 6:24 AM
Unknown Object (File)
Sun, Mar 1, 3:28 AM
Unknown Object (File)
Fri, Feb 27, 2:38 PM
Unknown Object (File)
Fri, Feb 27, 4:33 AM
Unknown Object (File)
Fri, Feb 27, 4:28 AM
Subscribers

Details

Summary

Hi,

I've found this PR to fix one of the not working master_sites url to updated one that supports tls v1.2. The 2nd URL works fine.

My very small fix to the patch was to remove the extra $DISTNAME that maintainer added to the new URL. So, creating a differential here. The maintainer has approved their patch.

I'll add these to commit message too:

Reported by: linimon@
Authored by: schaiba@gmail.com

Thanks in advance.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nxjoseph created this revision.

Suggest this patch to the maintainer in PR.

Also explain to him why his patch is incorrect.

In D55543#1270927, @vvd wrote:

Suggest this patch to the maintainer in PR.

Okay, they had been approved my patch.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292318#c4

Thank you.

This revision is now accepted and ready to land.Mon, Mar 2, 5:11 PM

I have tested the mirrors just to be sure before the commit and there's something different now, the second site gives 404. The original patch from the port maintainer was removing second site too but I was kept it then since it was working but it doesn't now. So I am agreeing on removing the 2nd site right now. What do you think? Thank you.

The second one doesn't contain this version, but it does contain many previous ones. Perhaps newer ones will appear there someday - who knows?
You can leave it as a potential backup. In any case, it will only be used if the download from the first one fails.

In D55543#1272662, @vvd wrote:

The second one doesn't contain this version, but it does contain many previous ones.

Right, it misses recent versions for now but rest are there.

Perhaps newer ones will appear there someday - who knows?

Yeah ๐Ÿ˜

You can leave it as a potential backup. In any case, it will only be used if the download from the first one fails.

I got it, okay.

Thank you.

This revision was automatically updated to reflect the committed changes.