Page MenuHomeFreeBSD
Differential D55524

diskinfo: Add libxo support to diskinfo
AbandonedPublic
Actions

Authored by imp on Wed, Feb 25, 10:34 PM.
Tags
None
Referenced Files
F146553300: D55524.diff
Tue, Mar 3, 2:48 PM
F146553191: D55524.diff
Tue, Mar 3, 2:47 PM
Unknown Object (File)
Sun, Mar 1, 6:24 AM
Unknown Object (File)
Sun, Mar 1, 3:47 AM
Unknown Object (File)
Sun, Mar 1, 3:40 AM
Unknown Object (File)
Sun, Mar 1, 3:40 AM
Unknown Object (File)
Sun, Mar 1, 3:40 AM
Unknown Object (File)
Sun, Mar 1, 3:34 AM
View All 21 Files
Subscribers
markj
ziaee

Details

Reviewers
None
Summary

I did this as an experimenet in claude. This is 20 minutes of effort.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71014
Build 67897: arc lint + arc unit

Event Timeline

imp requested review of this revision.Wed, Feb 25, 10:34 PM
imp created this revision.
Harbormaster completed remote builds in B71009: Diff 172714.Wed, Feb 25, 10:34 PM
imp updated this revision to Diff 172715.Wed, Feb 25, 10:48 PM

fix a number of regressions

Harbormaster completed remote builds in B71010: Diff 172715.Wed, Feb 25, 10:49 PM
imp updated this revision to Diff 172717.Wed, Feb 25, 11:33 PM

OK. --libxo is one path (it produces data from -v), everything else goes through
the old code paths...

Harbormaster completed remote builds in B71011: Diff 172717.Wed, Feb 25, 11:33 PM
imp updated this revision to Diff 172718.Wed, Feb 25, 11:37 PM

claude can be told to do the right thing...

Harbormaster completed remote builds in B71012: Diff 172718.Wed, Feb 25, 11:37 PM
imp updated this revision to Diff 172719.Wed, Feb 25, 11:49 PM

just the meat of the commit

Harbormaster completed remote builds in B71013: Diff 172719.Wed, Feb 25, 11:49 PM
imp updated this revision to Diff 172720.Thu, Feb 26, 12:09 AM

have claude gen a man page that I then tweaked a bit

Herald added a subscriber: ziaee. · View Herald TranscriptThu, Feb 26, 12:09 AM
Harbormaster completed remote builds in B71014: Diff 172720.Thu, Feb 26, 12:09 AM
markj added a subscriber: markj.Thu, Feb 26, 12:10 AM
markj added inline comments.
usr.sbin/diskinfo/diskinfo.c
197

Don't these prints need to be converted too?

imp added inline comments.Thu, Feb 26, 12:23 AM
usr.sbin/diskinfo/diskinfo.c
197

No. This is a slghtly atypical conversion. Only the datafrom -v is printed in json mode. It ignores all the other flags. Or should.. but that's not quite what the code actually does. I'll fix that.

imp abandoned this revision.Thu, Feb 26, 10:05 PM

I'm going to punt and try again later. Thanks for looking at this...

usr.sbin/diskinfo/diskinfo.c
251

So these iocts duplicate things here and also above...
It might make sense to refactor some of this...

Revision Contents
Changeset List

PathSize
usr.sbin/
diskinfo/
2 lines
25 lines
46 lines

Diff 172720

View Options

usr.sbin/diskinfo/Makefile

Loading...
View Options

usr.sbin/diskinfo/diskinfo.8

Loading...
View Options

usr.sbin/diskinfo/diskinfo.c

Loading...