Page MenuHomeFreeBSD

flua: Fix SIGSEGV in lua_chown when uid/gid doesn't exist
ClosedPublic

Authored by dtxdf on Sun, Feb 8, 12:01 AM.
Tags
None
Referenced Files
F144935756: D55172.diff
Sat, Feb 14, 7:02 AM
Unknown Object (File)
Wed, Feb 11, 11:34 PM
Unknown Object (File)
Wed, Feb 11, 2:54 PM
Unknown Object (File)
Wed, Feb 11, 7:41 AM
Unknown Object (File)
Wed, Feb 11, 7:29 AM
Unknown Object (File)
Tue, Feb 10, 5:53 AM
Unknown Object (File)
Sun, Feb 8, 12:50 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dtxdf requested review of this revision.Sun, Feb 8, 12:01 AM

Were you planning on pushing this into the src repo?
I'd add a note that says that both getpwnam_r and getgrnam_r return 0/NULL in this case to the commit message. If you add that, you can add 'Approved by: imp' to the commit since I don't think you have a src commit bit.
And we prefer you use -U99999 to get the context. Not a huge deal for this one, but something to note in the future.
If you'd prefer someone else commit this, I can do the deed.

This revision is now accepted and ready to land.Sun, Feb 8, 5:55 PM

Committed!

In D55172#1261760, @imp wrote:

And we prefer you use -U99999 to get the context. Not a huge deal for this one, but something to note in the future

And thanks for the tip about -U99999, I'll use it in the next case!

Committed!

Thanks for doing that!

In D55172#1261760, @imp wrote:

And we prefer you use -U99999 to get the context. Not a huge deal for this one, but something to note in the future

And thanks for the tip about -U99999, I'll use it in the next case!

You bet. Though if you do more than a couple more of these, you'd be better off getting 'git arc' working. Having branches, and rebasing and git arc update main..HEAD makes more complex submissions a breeze.