Details
Details
- Reviewers
imp - Commits
- rG436af5715cdb: flua: Fix SIGSEGV in lua_chown when uid/gid doesn't exist
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Were you planning on pushing this into the src repo?
I'd add a note that says that both getpwnam_r and getgrnam_r return 0/NULL in this case to the commit message. If you add that, you can add 'Approved by: imp' to the commit since I don't think you have a src commit bit.
And we prefer you use -U99999 to get the context. Not a huge deal for this one, but something to note in the future.
If you'd prefer someone else commit this, I can do the deed.
Comment Actions
Thanks for doing that!
And thanks for the tip about -U99999, I'll use it in the next case!
You bet. Though if you do more than a couple more of these, you'd be better off getting 'git arc' working. Having branches, and rebasing and git arc update main..HEAD makes more complex submissions a breeze.