Differential D5516

Use SCHEDULER_STOPPED() in cv_wait() instead of checking panicstr.
ClosedPublic
Actions

Authored by jhb on Mar 1 2016, 10:22 PM.

Details

Reviewers

kib

Commits

rS296283: Use SCHEDULER_STOPPED() in cv_*wait*() instead of checking panicstr.

Summary

Use SCHEDULER_STOPPED() in cv_*wait*() instead of checking panicstr.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 13955.Mar 1 2016, 10:22 PM

jhb retitled this revision from to Use SCHEDULER_STOPPED() in cv_*wait*() instead of checking panicstr..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: kib.

Herald added a subscriber: imp. · View Herald TranscriptMar 1 2016, 10:22 PM

Doesn't 'cold' accesses somewhat defeat the optimization of SCHEDULER_STOPPED() ?

This revision is now accepted and ready to land.Mar 1 2016, 10:34 PM

Possibly, but this is what the sleep functions in kern_synch.c do. Longer term I plan to split these up to permit unbounded sleeps while cold (I think I now want to just panic outright for sleeps with a timeout while cold. The round-robin thing I first implemented in my patch to arch@ wasn't that great since some code depends on actually sleeping for the requested time ala pause()).

Closed by commit rS296283: Use SCHEDULER_STOPPED() in cv_*wait*() instead of checking panicstr. (authored by jhb). · Explain WhyMar 1 2016, 10:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_condvar.c

10 lines

Diff 13956

View Options

head/sys/kern/kern_condvar.c

Use SCHEDULER_STOPPED() in cv_*wait*() instead of checking panicstr.ClosedPublicActions