ccp: Don't name anonymous structure and union types
ClosedPublic
Actions

Authored by jhb on Fri, Feb 6, 3:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 26, 1:36 AM

	Unknown Object (File)
	Thu, Feb 19, 10:59 PM

	Unknown Object (File)
	Thu, Feb 19, 12:24 AM

	Unknown Object (File)
	Sun, Feb 15, 9:45 AM

	Unknown Object (File)
	Sun, Feb 15, 5:05 AM

	Unknown Object (File)
	Thu, Feb 12, 1:21 PM

	Unknown Object (File)
	Wed, Feb 11, 4:08 PM

	Unknown Object (File)
	Sun, Feb 8, 10:45 AM

View All 9 Files

Subscribers

imp

Details

Reviewers

Commits

rG8d3f41dbcb2a: ccp: Don't name anonymous structure and union types

Summary

Keep the dword labels as comments instead. Anonymous structs and
unions don't have type names in C11+.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Fri, Feb 6, 3:28 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Feb 6, 3:28 PM

jhb requested review of this revision.Fri, Feb 6, 3:28 PM

Harbormaster completed remote builds in B70470: Diff 171336.Fri, Feb 6, 3:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Feb 24, 8:26 PM

Closed by commit rG8d3f41dbcb2a: ccp: Don't name anonymous structure and union types (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8d3f41dbcb2a: ccp: Don't name anonymous structure and union types.

I am sorry. I completely missed this (well never saw it).
That would have answered my question/poking from D55072.
Sorry and thank you!

Revision Contents
Changeset List

Path

Size

sys/

crypto/

ccp/

ccp_hardware.h

10 lines

modules/

ccp/

Makefile

3 lines

Diff 172625

View Options

sys/crypto/ccp/ccp_hardware.h