ccp: Don't name anonymous structure and union types
ClosedPublic
Actions

Authored by jhb on Feb 6 2026, 3:28 PM.

Tags

None

Referenced Files

	F157564836: D55144.id172625.diff
	Fri, May 22, 9:38 PM

	Unknown Object (File)
	Fri, May 22, 12:09 AM

	Unknown Object (File)
	Mon, May 18, 10:01 AM

	Unknown Object (File)
	Mon, May 18, 10:00 AM

	Unknown Object (File)
	Sun, May 17, 3:42 PM

	Unknown Object (File)
	Sun, May 17, 10:23 AM

	Unknown Object (File)
	Sat, May 16, 9:46 PM

	Unknown Object (File)
	Wed, May 13, 11:56 PM

View All 42 Files

Subscribers

imp

Details

Reviewers

Commits

rG2e3a575bf7a5: ccp: Don't name anonymous structure and union types
rG8d3f41dbcb2a: ccp: Don't name anonymous structure and union types

Summary

Keep the dword labels as comments instead. Anonymous structs and
unions don't have type names in C11+.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 6 2026, 3:28 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2026, 3:28 PM

jhb requested review of this revision.Feb 6 2026, 3:28 PM

Harbormaster completed remote builds in B70470: Diff 171336.Feb 6 2026, 3:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2026, 8:26 PM

Closed by commit rG8d3f41dbcb2a: ccp: Don't name anonymous structure and union types (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8d3f41dbcb2a: ccp: Don't name anonymous structure and union types.

I am sorry. I completely missed this (well never saw it).
That would have answered my question/poking from D55072.
Sorry and thank you!

jhb added a commit: rG2e3a575bf7a5: ccp: Don't name anonymous structure and union types.Fri, Apr 24, 5:56 PM

Revision Contents
Changeset List

Path

Size

sys/

crypto/

ccp/

ccp_hardware.h

10 lines

modules/

ccp/

Makefile

3 lines

Diff 172625

View Options

sys/crypto/ccp/ccp_hardware.h