Add system_percpu_wq as an alias for linux_system_short_wq for now.
A system_percpu_wq likely needs a lot more elaborated work if anything
beyond mt76 starts needing it.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Details
Details
- Reviewers
- None
- Group Reviewers
linuxkpi
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 70040 Build 66923: arc lint + arc unit
Event Timeline
| sys/compat/linuxkpi/common/src/linux_work.c | ||
|---|---|---|
| 726 | Can we expand the XXX, e.g. some details from the proposed commit message? | |
| sys/compat/linuxkpi/common/src/linux_work.c | ||
|---|---|---|
| 726 | How did you know I was going to get back to this one. I literally was thinking about it an hour ago. Turns out the system_wq was s///g with the system_percpu_wq in v6.18. alloc_workqueue() [linux_create_workqueue_common()] already starts n threads; the only thing we do not seem to do is bind each one to a CPU but doing so seems tricky with the current API unless we have another dedicated wq for percpu; I have no idea if any/all the "short" ones should have CPUs affinity but if they should be the system_wq should have been too. It seems the Linux Documentation was not updated to reflect this change at all. | |
Comment Actions
Abandon in favour of D57730 which is the exact same functional change but with a different comment message and comments.
(I couldn't find my original review anymore and was lazy).