LinuxKPI: add system_percpu_wq
Needs ReviewPublic
Actions

Authored by bz on Jan 21 2026, 2:02 PM.

Details

Reviewers

None

Group Reviewers

Summary

Add system_percpu_wq as an alias for linux_system_short_wq for now.
A system_percpu_wq likely needs a lot more elaborated work if anything
beyond mt76 starts needing it.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 70040
Build 66923: arc lint + arc unit

Event Timeline

bz created this revision.Jan 21 2026, 2:02 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJan 21 2026, 2:02 PM

bz requested review of this revision.Jan 21 2026, 2:02 PM

Harbormaster completed remote builds in B70040: Diff 170183.Jan 21 2026, 2:02 PM

bz added a child revision: D54841: LinuxKPI: exapnd dma_sync_single_for_cpu() in lkpi_dma_unmap().Feb 1 2026, 8:26 PM

bz removed a child revision: D54841: LinuxKPI: exapnd dma_sync_single_for_cpu() in lkpi_dma_unmap().Feb 4 2026, 10:06 PM

emaste added inline comments.Fri, Jun 5, 2:10 PM

sys/compat/linuxkpi/common/src/linux_work.c
726	Can we expand the XXX, e.g. some details from the proposed commit message?

bz added inline comments.Fri, Jun 5, 2:43 PM

sys/compat/linuxkpi/common/src/linux_work.c
726	How did you know I was going to get back to this one. I literally was thinking about it an hour ago. Turns out the system_wq was s///g with the system_percpu_wq in v6.18. And given we assign all "fast" wq to the short_wq rather than having one per (and extra threads) this seems fine even without the XXX. alloc_workqueue() [linux_create_workqueue_common()] already starts n threads; the only thing we do not seem to do is bind each one to a CPU but doing so seems tricky with the current API unless we have another dedicated wq for percpu; I have no idea if any/all the "short" ones should have CPUs affinity but if they should be the system_wq should have been too. It seems the Linux Documentation was not updated to reflect this change at all.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

workqueue.h

1 line

src/

linux_work.c

3 lines

Diff 170183

View Options

sys/compat/linuxkpi/common/include/linux/workqueue.h