Differential D54751

time: Add EXTERROR for all EINVAL returns OBSOLETE
Needs ReviewPublic
Actions

Authored by imp on Jan 16 2026, 9:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 5:47 AM

	Unknown Object (File)
	Fri, Sep 4, 8:44 PM

	Unknown Object (File)
	Fri, Sep 4, 6:37 PM

	Unknown Object (File)
	Thu, Sep 3, 6:13 AM

	Unknown Object (File)
	Thu, Sep 3, 3:53 AM

	Unknown Object (File)
	Tue, Sep 1, 2:58 AM

	Unknown Object (File)
	Tue, Sep 1, 2:45 AM

	Unknown Object (File)
	Sat, Aug 29, 9:01 PM

View All 70 Files

Subscribers

Details

Reviewers

Summary

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69938
Build 66821: arc lint + arc unit

Event Timeline

imp created this revision.Jan 16 2026, 9:10 PM

Herald added a subscriber: olce. · View Herald TranscriptJan 16 2026, 9:10 PM

imp requested review of this revision.Jan 16 2026, 9:10 PM

Harbormaster completed remote builds in B69938: Diff 169912.Jan 16 2026, 9:11 PM

imp mentioned this in D54746: Initialize CLOCK_UPTIME for itmer events.Jan 16 2026, 9:11 PM

kib added inline comments.Jan 16 2026, 9:37 PM

lib/libc/gen/exterr_cat_filenames.h
18	I suspect you have an old version of the tools/build/make_libc_exterr_cat_filenames.sh script. After today, the output of it should be stable, i..e. the diff should only show one line added for EXTERR_CAT_TIME.
sys/kern/kern_time.c
221	I suggest to add the actual values of the invalid parameters (use %jd or %ju or %jx as format). There and in all other places where it makes sense.
430

So I'm closing this one... I submitted it twice and there's more on the other ones.

sys/kern/kern_time.c
221	OK. Good suggestion. It also looks like I submitted this twice accidentally.

imp retitled this revision from time: Add EXTERROR for all EINVAL returns to time: Add EXTERROR for all EINVAL returns OBSOLETE.Apr 19 2026, 2:47 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

exterr_cat_filenames.h

sys/

kern/

54 lines

sys/

1 line

Diff 169912

lib/libc/gen/exterr_cat_filenames.h

Loading...

sys/kern/kern_time.c

Loading...

sys/sys/exterr_cat.h

Loading...