Differential D54751

time: Add EXTERROR for all EINVAL returns
Needs ReviewPublic
Actions

Authored by imp on Fri, Jan 16, 9:10 PM.

Tags

None

Referenced Files

	F143338890: D54751.diff
	Thu, Jan 29, 3:05 AM

	Unknown Object (File)
	Sun, Jan 25, 1:44 AM

	Unknown Object (File)
	Thu, Jan 22, 5:26 PM

	Unknown Object (File)
	Wed, Jan 21, 1:00 PM

	Unknown Object (File)
	Mon, Jan 19, 10:25 AM

	Unknown Object (File)
	Sun, Jan 18, 9:44 PM

	Unknown Object (File)
	Sun, Jan 18, 10:30 AM

	Unknown Object (File)
	Sat, Jan 17, 1:07 PM

View All 11 Files

Subscribers

Details

Reviewers

Summary

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69938
Build 66821: arc lint + arc unit

Event Timeline

imp created this revision.Fri, Jan 16, 9:10 PM

Herald added a subscriber: olce. · View Herald TranscriptFri, Jan 16, 9:10 PM

imp requested review of this revision.Fri, Jan 16, 9:10 PM

Harbormaster completed remote builds in B69938: Diff 169912.Fri, Jan 16, 9:11 PM

imp mentioned this in D54746: Initialize CLOCK_UPTIME for itmer events.Fri, Jan 16, 9:11 PM

kib added inline comments.Fri, Jan 16, 9:37 PM

lib/libc/gen/exterr_cat_filenames.h
18	I suspect you have an old version of the tools/build/make_libc_exterr_cat_filenames.sh script. After today, the output of it should be stable, i..e. the diff should only show one line added for EXTERR_CAT_TIME.
sys/kern/kern_time.c
221	I suggest to add the actual values of the invalid parameters (use %jd or %ju or %jx as format). There and in all other places where it makes sense.
430

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

exterr_cat_filenames.h

sys/

kern/

54 lines

sys/

1 line

Diff 169912

lib/libc/gen/exterr_cat_filenames.h

Loading...

sys/kern/kern_time.c

Loading...

sys/sys/exterr_cat.h

Loading...