Page MenuHomeFreeBSD

i2c(8) Support for I2CRDRW and change scan output
Needs ReviewPublic

Authored by manu_bidouilliste.com on Feb 27 2016, 3:12 AM.

Details

Reviewers
None
Group Reviewers
manpages
Summary

Creating a reviews based on my bugzilla entry: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198817

This add support for I2CRDRW ioctl (with option -x)
This also change the way scan outputs its result (this was asked from loos@ on irc a long time ago)

Test Plan

Apply patch and test i2c on a system with a without I2CRDRW.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2964
Build 2992: arc lint + arc unit

Event Timeline

manu_bidouilliste.com retitled this revision from to i2c(8) Support for I2CRDRW and change scan output.
manu_bidouilliste.com updated this object.
manu_bidouilliste.com edited the test plan for this revision. (Show Details)
manu_bidouilliste.com set the repository for this revision to rS FreeBSD src repository - subversion.
wblock added inline comments.
usr.sbin/i2c/i2c.8
29

Please bump this.

67

Kind of confusingly worded. How about:

8-bit hex address of the I2C device on which to operate.
93

The first sentence can be added to the end of the previous sentence:

scan the bus for devices and print a table of all addresses.

Then start the second sentence on a new line and s/those/these/

The content of each cell can have these meanings:
102

s/An/A/

Should that really be "if", or is it meant to be "of"?

105

"the" and "ones" are not needed:

Use the I2CRDRW ioctl instead of I2CREAD/I2CWRITE.
manu_bidouilliste.com edited edge metadata.

Fixes a few sentences.
Bump .Dd

manu_bidouilliste.com added inline comments.
usr.sbin/i2c/i2c.8
102

Both are correct for me but english isn't my native language so it might be better otherway.
I've changed it, tell me if it suits you.

usr.sbin/i2c/i2c.8
66–68

As below, how about:

7-bit hex address of the I2C device.
67

Missed a couple of things:

8-bit hex address of the I2C device on which to operate.

I'm actually not sure the last part of that is needed at all. How about:

8-bit hex address of the I2C device.
93

s/those/these/

93–107

s/address/addresses/

102

Looks good now, thanks!

105

Sorry, it needs the first "the":

Use **the** I2CRDRW ioctl instead of I2CREAD/I2CWRITE.
manu_bidouilliste.com edited edge metadata.
manu_bidouilliste.com marked an inline comment as done.

Fix a few words/sentences.

Just a couple of minor things. I will go back through and review later, but I think this is everything. Thank you!

usr.sbin/i2c/i2c.8
66–68

s/on/of/

67

s/on/of/

usr.sbin/i2c/i2c.8
101

This should be
"XX" The address was skipped
.Pq see Fl n

(Untested, but I think that is correct.)

I'll submit a new one after 11 is branched.