This fixes the UNKNOWN type returned by checkkey.sh
The EDDSA (22) has a dedicated standard (RFC8032),
and is also allowed for use in RFC9580 which obsoletes RFC4880.
Details
Details
- Reviewers
des markj - Commits
- R9:169c613a70b8: checkkey.sh: Add EDDSA algo (RFC8032)
To test you can use a key with algorithm number 22:
% ./documentation/tools/checkkey.sh C7E57F23C24F542D key C7E57F23C24F542D: EDDSA
Diff Detail
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Why don't we allow new committers to use curve algorithms?
I can see that there are multiple ed25519 keys currently in use by committers, as reported by ./doc/documentation/tools/pgpkeyreport.
However, committer's guide states that checkkey.sh must be used to ensure the key is valid.
The checkkey.sh script does not allow committers to use curve algorithms. Is this ok or should we write an exception for curve algorithms?
Comment Actions
There is no reason not to allow EDDSA. It just did not yet exist when this script was written.
| documentation/tools/checkkey.sh | ||
|---|---|---|
| 194 | Found this review by making the same local change myself. Yes, you will need to add a line here for EDDSA) ;; | |