Paths

Table of Contentst

remove -fPIC from linux modules link commandline
ClosedPublic
Actions

Authored by emaste on Feb 25 2016, 4:23 PM.

Details

Reviewers

kib
dchagin

Commits

rS296057: pass -fPIC to the assembler, not linker

Summary

It has no effect on linking, but seems to be ignored by GNU ld.bfd. It causes ld.lld to terminate with an invalid argument error.

(Perhaps it was intended to be passed to ${CC} not through -Wl, but it is currently not being compassed to the compiler driver and I don't think it's necessary anyway.)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 13730.Feb 25 2016, 4:23 PM

emaste retitled this revision from to remove -fPIC from linux modules link commandline.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: dchagin, kib.

Assembler can generate different object with and without -fPIC. I would prefer that -fPIC moved out of -Wl instead of removal.

pass -fPIC to the assembler, not linker

In effect we have been building without -fPIC so removing it won't break anything, but it should be passed to the assembler (compiler driver) .

kib accepted this revision.Feb 25 2016, 6:13 PM

kib edited edge metadata.

This revision is now accepted and ready to land.Feb 25 2016, 6:13 PM

dchagin accepted this revision.Feb 25 2016, 7:17 PM

dchagin edited edge metadata.

Closed by commit rS296057: pass -fPIC to the assembler, not linker (authored by emaste). · Explain WhyFeb 26 2016, 11:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

modules/

linux/

Makefile

4 lines

linux64/

Makefile

4 lines

Diff 13775

View Options

head/sys/modules/linux/Makefile