Page MenuHomeFreeBSD

[PATCH] Uses/zig.mk: fix zig-package extraction
Needs RevisionPublic

Authored by guest-svmhdvn on Sat, Dec 27, 1:55 PM.

Details

Summary

Dependencies listed in build.zon files could be tarballs
that contain:

  • a single directory
  • multiple files and directories
  • hidden files

This patch takes those into account when moving the extracted
contents into zig-packages.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

guest-svmhdvn created this revision.

I also notice that Uses/zig.mk is unmaintained. I have a few other fixes/improvements locally that I'd like to submit soon. I am willing to take over maintainership if necessary (I don't have a ports commit bit yet though).

Do you have a concrete example that this patch fixes? What hidden files would need to be considered?

I am trying to port https://github.com/neurosnap/zmx with this patch: {F140747876}. It pulls in dependencies that are tarballs reflecting the above examples in the patch description. Trying to build zmx without this patch fails. I'm sure many other zig projects with a decent number of recursive dependencies will have this issue.

make -C /home/charlie/src/freebsd-ports/x11/ghostty do-extract EXTRACT_ONLY=breakpad-b99f444ba5f6b98cac261cbb391d8766b34a5918.tar.gz WRKDIR=/home/charlie/src/freebsd-ports/x11/ghostty/work/zig-packages-tmp
/bin/mv /home/charlie/src/freebsd-ports/x11/ghostty/work/zig-packages-tmp/* /home/charlie/src/freebsd-ports/x11/ghostty/work/zig-packages/N-V-__8AALw2uwF_03u4JRkZwRLc3Y9hakkYV7NKRR9-RIZJ
mv: rename /home/charlie/src/freebsd-ports/x11/ghostty/work/zig-packages-tmp/breakpad-b99f444ba5f6b98cac261cbb391d8766b34a5918 to /home/charlie/src/freebsd-ports/x11/ghostty/work/zig-packages/N-V-__8AALw2uwF_03u4JRkZwRLc3Y9hakkYV7NKRR9-RIZJ: No such file or directory
*** Error code 1
This revision now requires changes to proceed.Sat, Dec 27, 3:23 PM