lua-language-server: update to 3.16.1 and add missing PORTEPOCH.
ClosedPublic
Actions

Authored by dave_freedave.net on Wed, Dec 10, 5:12 PM.

Details

Reviewers

adamw

Commits

R11:8e5f603baea2: devel/lua-language-server: Update to 3.16.1 and restore PORTEPOCH

Summary

I missed PORTEPOCH in original port. Adding it back for correct sort behaviour.
And a new version came out.

Test Plan

In stable/14, stable/15, and main:

cd /usr/ports/devel/lua-language-server
make test

And I like to fire up neovim and see if it reports errors bringing up my lua config.

portlint -A, portclippy --strict Makefile, and a poudriere testbuild.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dave_freedave.net requested review of this revision.Wed, Dec 10, 5:12 PM

dave_freedave.net created this revision.

{F139313289} log file from poudriere testport -j 15R -p local devel/lua-language-server

dave_freedave.net edited the test plan for this revision. (Show Details)Wed, Dec 10, 6:27 PM

Actually I do have portlint -A outpout:

WARN: Makefile: new ports should not set PORTEPOCH.

But that is intentional.

Good test plan! I also find :checkhealth to be helpful, if you bring up a buffer with lua_ls attached.

adamw added inline comments.Wed, Dec 10, 8:54 PM

devel/lua-language-server/Makefile
21	Harmless, but: You sure you want to update this comment on every update? Sticking a placeholder in for the hash may get you what you need...

Just on inspection, this looks good. I'll get it committed this evening.

dave_freedave.net added inline comments.Wed, Dec 10, 10:15 PM

devel/lua-language-server/Makefile
21	I'm giving submodules2tuple a go instead of me doing by hand. One sec...

Yeah using the submodule2tuple shows I neglected a submodule:
actboy168:ltest:0d2d81f:ltest/3rd/json.lua/test/ltest

It does get tripped up by the fact bee.lua is fetched twice and requires a tiny bit of manual intervention. But long term that will be better than manual and having comments that get out of date.

switched to using ports-mgmt/submodules2tuple to do the initial pass.

Unfortunately I had used the SHA1 from looking at github which has 8 character hashes. The tool used 7 character. This blows up the distfiles cache. But I think its worth the better reliability of the automated tool (already found I missed a unit test for a submodule).

Just to be sure rebuilt and retested.

dave_freedave.net marked an inline comment as done.Wed, Dec 10, 11:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Dec 11, 3:12 AM

Closed by commit R11:8e5f603baea2: devel/lua-language-server: Update to 3.16.1 and restore PORTEPOCH (authored by dave_freedave.net, committed by adamw). · Explain Why

This revision was automatically updated to reflect the committed changes.

adamw added a commit: R11:8e5f603baea2: devel/lua-language-server: Update to 3.16.1 and restore PORTEPOCH.