Page MenuHomeFreeBSD

bus: Return 0 if reading an ivar fails
ClosedPublic

Authored by des on Dec 4 2025, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 25, 1:07 AM
Unknown Object (File)
Tue, Mar 17, 9:03 PM
Unknown Object (File)
Tue, Mar 17, 10:13 AM
Unknown Object (File)
Mon, Mar 16, 11:42 PM
Unknown Object (File)
Feb 18 2026, 3:08 AM
Unknown Object (File)
Feb 15 2026, 11:31 AM
Unknown Object (File)
Feb 7 2026, 9:00 PM
Unknown Object (File)
Feb 7 2026, 6:39 PM
Subscribers

Details

Summary

In the non-INVARIANTS case, return 0 rather than stack garbage if
reading an ivar fails (in the INVARIANTS case, we still panic).

MFC after: 1 week
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Dec 4 2025, 9:01 PM

Hmmm, I wonder if 0 is the right thing vs something like 0xdeadc0de. We have a few explicit IVAR handlers that intentionally return a default value (e.g. acpi_get_handle()) and those do tend to be zero (and in those cases we don't KASSERT). I have a patch in a branch to add a new one like that for ThunderBolt PCI bridges even. 0 is probably fine as a default, but @imp might also have an opinion.

This revision is now accepted and ready to land.Dec 5 2025, 1:16 PM
This revision was automatically updated to reflect the committed changes.