Page MenuHomeFreeBSD

tzcode: Fix early tz change detection
ClosedPublic

Authored by des on Oct 31 2025, 5:16 PM.
Tags
None
Referenced Files
F154223186: D53502.id165589.diff
Mon, Apr 27, 5:58 AM
F154213972: D53502.id165673.diff
Mon, Apr 27, 4:23 AM
Unknown Object (File)
Sun, Apr 19, 7:43 AM
Unknown Object (File)
Tue, Apr 14, 11:30 AM
Unknown Object (File)
Sat, Apr 11, 10:01 PM
Unknown Object (File)
Fri, Apr 10, 8:30 PM
Unknown Object (File)
Fri, Apr 10, 1:59 PM
Unknown Object (File)
Fri, Apr 10, 1:28 AM
Subscribers

Details

Summary

Assume tzdata is not fresh if last_checked is zero, as comparing the
current time to last_checked less than __tz_change_interval after boot
may produce a false negative.

While here, invert the return value from tzdata_is_fresh() to better
match its new name (it was previously called recheck_tzdata(), so zero
for fresh and non-zero for stale made sense, but it doesn't now).

PR: 269207
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Oct 31 2025, 5:16 PM

initializing last_checked to TIME_T_MIN did not work, presumably because the subtraction overflowed, so explicitly check for zero instead.

This revision is now accepted and ready to land.Nov 2 2025, 12:14 AM
This revision was automatically updated to reflect the committed changes.