tests/sys/geom/class/label/basic.sh
33	There's no cleanup method either. Either add one, or else remove the cleanup keyword.
52	`detach_md` should be moved to a cleanup method, so it will still be executed on failure. I suggest using tests/sys/geom/class/nop/nop_test.sh as an example.
58	I suggest you rename the test, since it doesn't actually exercise the `create` command.

This revision now requires changes to proceed.Oct 17 2025, 8:17 PM

Address feedback

Harbormaster completed remote builds in B67883: Diff 164456.Oct 17 2025, 8:41 PM

Thanks for the feedback

LGTM

This revision is now accepted and ready to land.Oct 17 2025, 8:48 PM

Closed by commit rGe868a2026635: glabel: add a basic test (authored by brd). · Explain WhyOct 17 2025, 9:02 PM

This revision was automatically updated to reflect the committed changes.

brd added a commit: rGe868a2026635: glabel: add a basic test.

Thanks!

I think this commit is missing an addition to BSD.tests.dist because I get an error during make installworld. I've posted a quick github PR here, could you review and merge if it's correct? https://github.com/freebsd/freebsd-src/pull/1877

In D53178#1214927, @guest-svmhdvn wrote:

I think this commit is missing an addition to BSD.tests.dist because I get an error during make installworld. I've posted a quick github PR here, could you review and merge if it's correct? https://github.com/freebsd/freebsd-src/pull/1877

Cool, thanks!