Page MenuHomeFreeBSD

mfc-candidates.lua: add -F fmt option
AcceptedPublic

Authored by bz on Fri, Oct 17, 5:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 11:59 AM
Unknown Object (File)
Sat, Oct 18, 12:32 AM
Unknown Object (File)
Fri, Oct 17, 9:20 PM
Unknown Object (File)
Fri, Oct 17, 8:32 PM
Unknown Object (File)
Fri, Oct 17, 7:08 PM
Unknown Object (File)
Fri, Oct 17, 6:55 PM
Unknown Object (File)
Fri, Oct 17, 6:28 PM
Subscribers

Details

Reviewers
emaste
Summary

Add -F fmt option to give a free format string to git show --pretty=.
It can be used, for example, as:
./tools/tools/git/mfc-candidates.lua -X exclude-list-15 -F "%h %cD %s"
to see which commits have passed the minimum 3 days of waiting before
MFCing, ot to see which group of commits belong together.

MFC after: 3 days

Test Plan

A take add adding the option to specify the git show format.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67877
Build 64760: arc lint + arc unit

Event Timeline

bz requested review of this revision.Fri, Oct 17, 5:06 PM
This comment was removed by bz.

LGTM with one pedantic nit

tools/tools/git/mfc-candidates.lua
120

I guess we should sort the options. We have examples in the tree already for both -F -f -t -u -X (alpha order, uppercase first) and -F -X -f -t -u

bz edited the test plan for this revision. (Show Details)

I do not like either option particularly well as I would have
preferred to keep the "important" options first but this seems
less intrusive.

bz marked an inline comment as done.Fri, Oct 17, 5:43 PM
This revision is now accepted and ready to land.Fri, Oct 17, 5:44 PM