Page MenuHomeFreeBSD

Uses/display.mk: Overhaul the module
ClosedPublic

Authored by arrowd on Oct 15 2025, 4:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 29, 12:38 PM
Unknown Object (File)
Wed, Mar 25, 9:09 PM
Unknown Object (File)
Tue, Mar 24, 7:28 PM
Unknown Object (File)
Sun, Mar 22, 2:57 AM
Unknown Object (File)
Sun, Mar 8, 1:52 PM
Unknown Object (File)
Sat, Mar 7, 1:36 AM
Unknown Object (File)
Feb 16 2026, 12:10 AM
Unknown Object (File)
Feb 16 2026, 12:10 AM
Subscribers

Details

Summary
  • Stop determining the free display port number. The whole block is under the !defined(DISPLAY) condition and at the time Xvfb starts the :0 port is guaranteed to be available.
  • Allow multiple values in the USES args.
  • Set *_ENV and *_DEPENDS more granularly.
Test Plan

This fixes lang/seed7 breakage introduced with my previous commit
https://lists.freebsd.org/archives/dev-commits-ports-all/2025-October/177617.html

I also tested it against x11-toolkits/gtk30.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arrowd created this revision.
bapt added inline comments.
Mk/Uses/display.mk
33

in my opinion we shoud reject all arguments but build and test until someone comes with a use case for other situations
this should become something like

.if ${display_args:Mbuild} || empty(display_args)
MAKE_ENV+= DISPLAY...
.elif ${display_args:Mtest}
TEST_ENV:+ DISPLAY...
.else
.error invalid argument
.endif

DISPLAY_DEPENDS= ${dipslay_ARGS:U}_DEPENDS
arrowd added inline comments.
Mk/Uses/display.mk
33

It is not possible to do DISPLAY_DEPENDS= ${dipslay_ARGS:U}_DEPENDS, because dipslay_ARGS may have multiple words.

This revision is now accepted and ready to land.Oct 20 2025, 1:23 PM
This revision was automatically updated to reflect the committed changes.
arrowd marked an inline comment as done.