Page MenuHomeFreeBSD

Uses/display.mk: Overhaul the module
ClosedPublic

Authored by arrowd on Oct 15 2025, 4:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 6, 9:23 AM
Unknown Object (File)
Sat, Dec 6, 9:23 AM
Unknown Object (File)
Fri, Dec 5, 4:22 PM
Unknown Object (File)
Wed, Nov 26, 10:34 AM
Unknown Object (File)
Tue, Nov 18, 9:21 PM
Unknown Object (File)
Thu, Nov 13, 10:28 AM
Unknown Object (File)
Thu, Nov 13, 5:52 AM
Unknown Object (File)
Wed, Nov 12, 3:07 AM
Subscribers

Details

Summary
  • Stop determining the free display port number. The whole block is under the !defined(DISPLAY) condition and at the time Xvfb starts the :0 port is guaranteed to be available.
  • Allow multiple values in the USES args.
  • Set *_ENV and *_DEPENDS more granularly.
Test Plan

This fixes lang/seed7 breakage introduced with my previous commit
https://lists.freebsd.org/archives/dev-commits-ports-all/2025-October/177617.html

I also tested it against x11-toolkits/gtk30.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arrowd created this revision.
bapt added inline comments.
Mk/Uses/display.mk
33

in my opinion we shoud reject all arguments but build and test until someone comes with a use case for other situations
this should become something like

.if ${display_args:Mbuild} || empty(display_args)
MAKE_ENV+= DISPLAY...
.elif ${display_args:Mtest}
TEST_ENV:+ DISPLAY...
.else
.error invalid argument
.endif

DISPLAY_DEPENDS= ${dipslay_ARGS:U}_DEPENDS
arrowd added inline comments.
Mk/Uses/display.mk
33

It is not possible to do DISPLAY_DEPENDS= ${dipslay_ARGS:U}_DEPENDS, because dipslay_ARGS may have multiple words.

This revision is now accepted and ready to land.Oct 20 2025, 1:23 PM
This revision was automatically updated to reflect the committed changes.
arrowd marked an inline comment as done.