sockstat: Fix build reproducibility

[cperciva]

Summary

Both usr.bin/sockstat and usr.bin/sockstat/tests build the file
src/usr.bin/sockstat/sockstat.c.  Unfortunately, they place the
resulting object file in the same place, but produce different
files due to paths appearing in the .debug files; this results
in different binaries depending on how the race between the two
builds ends.

Use .PATH to tell make to find sockstat.c in the parent directory
but place the object file in the current object directory, rather
than placing '..' into the name of the source file.

Suggested by:   bdrewery, emaste, jrtc27
MFC after:      5 minutes (15.0 build fix)
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D53032

[bdrewery]

usr.bin/sockstat/tests/Makefile

2–3

Try just .PATH: ${.CURDIR:H} (which is .PATH: ${.CURDIR}/... It should keep 1 copy of the source file but have per-dir object files.

[bdrewery]

usr.bin/sockstat/tests/Makefile

2–3

To be clear, keep your patch as-is except remove the cp target. Add .PATH line anywhere.

[cperciva]

Use .PATH.

[bdrewery]

usr.bin/sockstat/tests/Makefile

3

My example had some unintended excess spaces after .PATH:. Is your spacing intended?

[cperciva]

usr.bin/sockstat/tests/Makefile

3

It's a single tab character, phabricator just mangles it.