Page MenuHomeFreeBSD
Differential D52926

cp: Simplify sameness checks
ClosedPublic
Actions

Authored by des on Oct 6 2025, 9:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 19, 6:31 AM
Unknown Object (File)
Tue, Apr 14, 4:55 PM
Unknown Object (File)
Tue, Apr 14, 4:36 PM
Unknown Object (File)
Sat, Apr 11, 6:47 PM
Unknown Object (File)
Tue, Apr 7, 5:12 PM
Unknown Object (File)
Mon, Apr 6, 3:51 PM
Unknown Object (File)
Sun, Apr 5, 9:40 PM
Unknown Object (File)
Sat, Apr 4, 11:25 AM
View All 52 Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rGb0c147af0862: cp: Simplify sameness checks
rGef8420744e72: cp: Simplify sameness checks
rG74fa49276487: cp: Simplify sameness checks
rG95de78614a57: cp: Simplify sameness checks
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Oct 6 2025, 9:25 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 6 2025, 9:25 AM
Harbormaster completed remote builds in B67578: Diff 163618.Oct 6 2025, 9:25 AM
des requested review of this revision.Oct 6 2025, 9:25 AM
markj added a subscriber: markj.Oct 6 2025, 12:01 PM
markj added inline comments.
bin/cp/tests/cp_test.sh
93
des added inline comments.Oct 6 2025, 12:43 PM
bin/cp/tests/cp_test.sh
93

You are correct, but now I'm wondering why the tests passed when I ran them after patching...

des added inline comments.Oct 6 2025, 12:45 PM
bin/cp/tests/cp_test.sh
93

Oh, they passed because I forgot make install...

des updated this revision to Diff 163623.Oct 6 2025, 12:47 PM

rf

Harbormaster completed remote builds in B67583: Diff 163623.Oct 6 2025, 12:47 PM
des marked an inline comment as done.Oct 6 2025, 12:47 PM
markj accepted this revision as: markj.Oct 6 2025, 12:53 PM
This revision is now accepted and ready to land.Oct 6 2025, 12:53 PM
Closed by commit rG95de78614a57: cp: Simplify sameness checks (authored by des). · Explain WhyOct 7 2025, 4:25 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG95de78614a57: cp: Simplify sameness checks.
des added a commit: rG74fa49276487: cp: Simplify sameness checks.Oct 9 2025, 12:22 PM
des added a commit: rGef8420744e72: cp: Simplify sameness checks.
des added a commit: rGb0c147af0862: cp: Simplify sameness checks.Oct 9 2025, 12:27 PM

Revision Contents
Changeset List

PathSize
bin/
cp/
tests/
8 lines

Diff 163705

View Options

bin/cp/tests/cp_test.sh

Loading...