Move kernel module options to kern.opts.mk so we can build modules from a naked sys tree as well as the kernel.

[imp]

You mentioned this on the list as broken, and I didn't know that this is what you meant. This should fix it. Please let me know if there are other build issues.

[jhb]

Let me try this. I think you had posted a variant of this before at BSDCan? This is indeed the only issue I currently see (that I am aware of)

Is there any reason you can think that this should be using SYSDIR instead of .CURDIR? (Though maybe that wouldn't work for the standalone "cd /sys/modules/foo; make" case?)

[imp]

(I don't think I had a variation of this patch before bsdcan, but I could be wrong)

I didn't think SYSDIR was guaranteed to be defined. I think that it might be better to define one, if possible. The standalone case makes it harder. We get around that with bsd.kmod.mk, and we could do similar things for this too so we get the matching kern.opts.mk file...

[imp]

20 modules makefiles files have something that looks like:
SYSDIR?=../../..
in them. Perhaps we should exploit that?

On the other hand, I'd rather we have a bsd.kopt.mk that we include at the top of this file that
will define SYSDIR (ala the current bsd.kmod.mk) as well as the .mk files so that these 20 files
could be converted over.

However, that solution would require the very -m flags we are looking to avoid, or lots of
transitionary special code in each file, no?

[jhb]

If you install bsd.kopt.mk into /usr/share/mk you wouldn't need the -m hack. It could be a wrapper ala bsd.kmod.mk that just determines SYSDIR so that other includes can depend on that. Not sure if we could get by only having a single bsd.<foo>.mk that gets installed to /usr/share/mk to set SYSDIR and then change module Makefile's to include SYSDIR/conf/bsd.kopts.mk and SYSDIR/conf/kmod.mk (could call it conf/kopts.mk perhaps?)

[imp]

I'm about to update the patch. After fixing the opt_inet.h issues, the number of Makefiles that need the include is much much smaller. I've started to define SYSDIR conditionally and use it in preference to the CURDIR/../../etc junk. I'm not quite ready to push to installing a new kern.opts.mk-type file. I think we really need to unify the one and a half different build systems we have in the system today...

[imp]

Update after other changes designed to reduce the scope of the change.

Updating D529: Move kernel module options to kern.opts.mk so we can build modules

from a naked sys tree as well as the kernel.

[imp]

Closed by commit rS269812 (authored by @imp).