nuageinit: Ignore non-existent groups
ClosedPublic
Actions

Authored by dtxdf on Thu, Sep 25, 12:56 AM.

Details

Reviewers

Commits

rG205797b9ef9d: nuageinit: Ignore non-existent groups
rG6c6b157a9fb7: nuageinit: Ignore non-existent groups
rG68691160f41b: nuageinit: Ignore non-existent groups

Summary

In cloud-init, when a group specified in the users.{index}.groups parameter does not exist, it is ignored, but the user is created anyway. In the case of nuageinit, it exits with an exception, since pw(8) expects each group to exist.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dtxdf created this revision.Thu, Sep 25, 12:56 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 25, 12:56 AM

dtxdf requested review of this revision.Thu, Sep 25, 12:56 AM

bapt accepted this revision.Thu, Sep 25, 6:46 AM

bapt added inline comments.

libexec/nuageinit/nuage.lua
219	Just a comment here would probably help anyone reading this part of the code in a few years.

This revision is now accepted and ready to land.Thu, Sep 25, 6:46 AM

Committed and comment already added. Thanks!

Closed by commit rG68691160f41b: nuageinit: Ignore non-existent groups (authored by dtxdf). · Explain WhySat, Sep 27, 10:08 PM

This revision was automatically updated to reflect the committed changes.

dtxdf added a commit: rG68691160f41b: nuageinit: Ignore non-existent groups.

bapt added a commit: rG6c6b157a9fb7: nuageinit: Ignore non-existent groups.Tue, Oct 7, 6:51 AM

bapt added a commit: rG205797b9ef9d: nuageinit: Ignore non-existent groups.

Revision Contents
Changeset List

Path

Size

libexec/

nuageinit/

nuage.lua

61 lines

Diff 162958

View Options

libexec/nuageinit/nuage.lua

nuageinit: Ignore non-existent groupsClosedPublicActions