Page MenuHomeFreeBSD

sys/bus.h: Indent tweeks
Needs ReviewPublic

Authored by zlei on Thu, Sep 18, 9:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:34 AM
Unknown Object (File)
Fri, Oct 10, 12:50 AM
Unknown Object (File)
Fri, Oct 10, 12:50 AM
Unknown Object (File)
Thu, Oct 9, 8:40 PM
Unknown Object (File)
Thu, Oct 9, 8:05 PM
Unknown Object (File)
Thu, Oct 9, 2:11 AM
Unknown Object (File)
Fri, Oct 3, 9:49 AM
Unknown Object (File)
Wed, Oct 1, 9:21 AM
Subscribers
None

Details

Reviewers
imp
kib

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Thu, Sep 18, 9:57 AM
zlei created this revision.
sys/sys/bus.h
206

I think

--- typedef struct devclass		*devclass_t;
+++ typedef struct devclass *	devclass_t;

the latter is much more clear.

822

Well, I'd personally prefer the previous style. This is different from variables those save pointers. @imp Any thoughts ?

sys/sys/bus.h
55

We usually align enums by putting tabs between symbol and '=', then just a space between '=' and initializer.

I do not want to spend too much time looking for enum example, I remember e.g. sys/amd64/amd64/trap.c trap_msg[] designated initialization.

98

Since you are changing each line, make all the constants same length by prepending enough zeros.

206

No, the existing formatting is right. It is not stylish to use tabs in typedef.

275

Like this, yes, but you would do it e.g. by two tabs for each enum member.

319

I would removed tab from r_vaddr instead.

326

And there I would put just one space, leaving other lines intact.

366

I do not think neither old nor new formatting is stylish. Style suggests to fill as much as possible before splitting the line.

822

New formatting is correct.