Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
sys/sys/bus.h | ||
---|---|---|
55 | We usually align enums by putting tabs between symbol and '=', then just a space between '=' and initializer. I do not want to spend too much time looking for enum example, I remember e.g. sys/amd64/amd64/trap.c trap_msg[] designated initialization. | |
98 | Since you are changing each line, make all the constants same length by prepending enough zeros. | |
206 | No, the existing formatting is right. It is not stylish to use tabs in typedef. | |
275 | Like this, yes, but you would do it e.g. by two tabs for each enum member. | |
319 | I would removed tab from r_vaddr instead. | |
326 | And there I would put just one space, leaving other lines intact. | |
366 | I do not think neither old nor new formatting is stylish. Style suggests to fill as much as possible before splitting the line. | |
822 | New formatting is correct. |