Page MenuHomeFreeBSD
Differential D5252

netfront: remove useless NULL check in netif_free
ClosedPublic
Actions

Authored by liuw_liuw.name on Feb 11 2016, 11:40 AM.
Tags
None
Referenced Files
F155199409: D5252.diff
Sat, May 2, 4:08 AM
Unknown Object (File)
Wed, Apr 29, 11:19 AM
Unknown Object (File)
Fri, Apr 24, 4:38 AM
Unknown Object (File)
Mar 8 2026, 12:37 AM
Unknown Object (File)
Feb 26 2026, 6:16 AM
Unknown Object (File)
Feb 21 2026, 8:04 PM
Unknown Object (File)
Feb 20 2026, 6:40 PM
Unknown Object (File)
Feb 20 2026, 6:40 PM
View All 78 Files
Subscribers
imp

Details

Reviewers
royger
Commits
rS295513: xen-netfront: remove useless NULL check in netif_free
Summary

xn_ifp is allocated in create_netdev with if_alloc(IFT_ETHER).
According to the current arrangement it can't be NULL.

This is CID 1349805.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

liuw_liuw.name updated this revision to Diff 13214.Feb 11 2016, 11:40 AM
liuw_liuw.name retitled this revision from to netfront: remove useless NULL check in netif_free.
liuw_liuw.name updated this object.
liuw_liuw.name edited the test plan for this revision. (Show Details)
liuw_liuw.name added a reviewer: royger.
Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2016, 11:40 AM
royger accepted this revision.Feb 11 2016, 11:54 AM
royger edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2016, 11:54 AM
Closed by commit rS295513: xen-netfront: remove useless NULL check in netif_free (authored by royger). · Explain WhyFeb 11 2016, 11:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
xen/
netfront/
8 lines

Diff 13219

View Options

head/sys/dev/xen/netfront/netfront.c

Loading...