Details

Reviewers

sunpoet
koobs
feld

Commits

rP408930: MFH: r408929

Summary

Proposed commit log:

www/nghttp2: Update to version 1.7.1

  - Convert MASTER_SITES to USE_GITHUB
    - Remove USES=tar:xz
  - Remove unneeded RUN_DEPENDS
  - Add USES=autoreconf
  - Fix pkgconfig path
  - Remove defunct configure jemalloc fix
  - Fix LDFLAGS -ldl problem

Reviewed_by:	sunpoet (maintainer), koobs (mentor), feld (mentor)
Approved by:	(maintainer), (mentor)
Differential_Revision:	D5218
MFH:		2016Q1

Test Plan

portlint -AC (clean)
poudriere testport
build mod_http2 1.2.4, run apache24 (OK, see comment)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brnrd updated this revision to Diff 13088.Feb 6 2016, 12:04 PM

brnrd retitled this revision from to www/nghttp2: Update to version 1.7.0.

brnrd updated this object.

brnrd edited the test plan for this revision. (Show Details)

brnrd added reviewers: sunpoet, koobs, feld.

Apache error-log

[Sat Feb 06 13:07:05.454966 2016] [http2:info] [pid 17200] mod_http2 (v1.2.4, nghttp2 1.7.0), initializing...
[Sat Feb 06 13:07:05.581811 2016] [mpm_prefork:notice] [pid 17200] AH00163: Apache/2.4.18 (FreeBSD) LibreSSL/2.3.2 configured -- resuming normal operations

curl output

* SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
* ALPN, server accepted to use h2

brnrd edited the test plan for this revision. (Show Details)Feb 6 2016, 12:16 PM

koobs requested changes to this revision.Feb 6 2016, 12:34 PM

koobs edited edge metadata.

koobs added inline comments.

www/nghttp2/Makefile
21 ↗	(On Diff #13088)	The LIB_DEPEBDS above imply RUN time dependencies. I don't believe this is needed, nor am I sure its (:=) recommended any longer
68 ↗	(On Diff #13088)	USES=pathfix on Makefile.{in,am} instead
www/nghttp2/files/patch-configure.ac
1 ↗	(On Diff #13088)	Add patch header comment, breadcrumbs & references if applicable

This revision now requires changes to proceed.Feb 6 2016, 12:34 PM

Use pathfix to fix .pc location, annotate patch

brnrd marked 3 inline comments as done.Feb 6 2016, 12:54 PM

brnrd added inline comments.

www/nghttp2/Makefile
68 ↗	(On Diff #13089)	Changed, works fine
21 ↗	(On Diff #13088)	As this is not my port, that is for @sunpoet to decide.

Worst rationale ever, but OK. :]

This revision is now accepted and ready to land.Feb 6 2016, 12:59 PM

Remove RUN_DEPENDS, upstream libdl fix

This revision now requires review to proceed.Feb 6 2016, 1:50 PM

brnrd added inline comments.Feb 6 2016, 1:53 PM

www/nghttp2/Makefile
20–21 ↗	(On Diff #13092)	Without RUN_DEPENDS, the package still reports correct dependencies. deps: { libev: { origin: "devel/libev", version: "4.20,1" }, shlibs_required: [ "libev.so.4", }