Page MenuHomeFreeBSD
Differential D51832

stdio: Fix bug in integer-parsing FSM
ClosedPublic
Actions

Authored by des on Aug 8 2025, 6:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 11:54 PM
Unknown Object (File)
Thu, Oct 9, 11:54 PM
Unknown Object (File)
Thu, Oct 9, 11:54 PM
Unknown Object (File)
Thu, Oct 9, 7:59 PM
Unknown Object (File)
Thu, Oct 9, 5:21 PM
Unknown Object (File)
Thu, Oct 9, 5:17 PM
Unknown Object (File)
Fri, Oct 3, 6:25 PM
Unknown Object (File)
Thu, Oct 2, 12:13 AM
View All 23 Files
Subscribers
imp

Details

Reviewers
mandree
diizzy
Commits
rG89906b9b20fd: stdio: Fix bug in integer-parsing FSM
rG602e98dd35ea: stdio: Fix bug in integer-parsing FSM
Summary

If we encounter a zero in the havezero state, we should assume octal,
just like we would if we encountered any other digit below 8.

MFC after: 1 week
PR: 288440
Fixes: d9dc1603d6e4

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Aug 8 2025, 6:33 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 8 2025, 6:33 PM
des requested review of this revision.Aug 8 2025, 6:33 PM
Harbormaster completed remote builds in B66121: Diff 160081.Aug 8 2025, 6:33 PM
mandree accepted this revision.Aug 8 2025, 10:03 PM

Code reviewed -> implementation makes sense to me.
Practice -> patched 14.3-RELEASE-p1's source tree with this patch, tested my demo program from PR 284400 -> bug fixed.

Thank you!

This revision is now accepted and ready to land.Aug 8 2025, 10:03 PM
mandree added a reviewer: diizzy.Aug 8 2025, 10:04 PM
Closed by commit rG602e98dd35ea: stdio: Fix bug in integer-parsing FSM (authored by des). · Explain WhyAug 8 2025, 10:47 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG602e98dd35ea: stdio: Fix bug in integer-parsing FSM.
des added a commit: rG89906b9b20fd: stdio: Fix bug in integer-parsing FSM.Aug 14 2025, 4:04 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
stdio/
5 lines
5 lines
tests/
stdio/
25 lines
25 lines

Diff 160095

View Options

lib/libc/stdio/vfscanf.c

Loading...
View Options

lib/libc/stdio/vfwscanf.c

Loading...
View Options

lib/libc/tests/stdio/sscanf_test.c

Loading...
View Options

lib/libc/tests/stdio/swscanf_test.c

Loading...