Page MenuHomeFreeBSD

libc: stop trying to create __<syscall> symbols
ClosedPublic

Authored by brooks on Aug 1 2025, 12:35 PM.
Tags
None
Referenced Files
F167518674: D51668.id159541.diff
Sat, Aug 22, 10:42 AM
Unknown Object (File)
Sun, Aug 16, 2:57 PM
Unknown Object (File)
Thu, Aug 13, 3:06 AM
Unknown Object (File)
Thu, Aug 13, 12:11 AM
Unknown Object (File)
Mon, Aug 10, 11:43 AM
Unknown Object (File)
Sat, Aug 8, 5:07 PM
Unknown Object (File)
Sat, Aug 8, 11:45 AM
Unknown Object (File)
Sat, Aug 8, 5:22 AM
Subscribers

Details

Summary

When we switched to an interposing table (commit 8495e8b1e9e1) for
cancelation points we stopped having concrete implementations of
<syscall> and instead use sys_<syscall> and __thr_<syscall>.
These entries of the form:

weak_reference(sys_<syscall>, __<syscall>);

seem to be intended to preserve these symbols, but they have no effect
as __sys_<syscall> isn't defined in the translation units in question.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I have half a memory of this pattern being added to the mix as a compat bridge when moving away from libcR... but it's clear they'd have no effect now

This revision is now accepted and ready to land.Aug 1 2025, 5:50 PM