Page MenuHomeFreeBSD

comsat: Don't read arbitrary files
ClosedPublic

Authored by des on Jul 27 2025, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 12:12 PM
Unknown Object (File)
Mon, Oct 13, 12:12 PM
Unknown Object (File)
Mon, Oct 13, 12:12 PM
Unknown Object (File)
Sun, Oct 12, 11:32 PM
Unknown Object (File)
Sun, Oct 12, 12:06 PM
Unknown Object (File)
Wed, Oct 8, 4:10 AM
Unknown Object (File)
Mon, Oct 6, 4:33 PM
Unknown Object (File)
Mon, Sep 22, 9:40 PM
Subscribers

Details

Summary

When processing a notification, instead of accepting any file name
that doesn't begin with a slash, accept only file names that don't
contain any slashes at all. This makes it possible to notify a
user about a mailbox that doesn't bear their name, as long as they
are permitted to read it, but prevents comsat from reading files
outside the mail spool.

PR: 270404
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jul 27 2025, 7:48 PM

Sorry, just realized this is incomplete. Will update in a bit.

Maybe we want to just discard a notification with a / in it rather than falling back to name (but I'm fine either way)

libexec/comsat/comsat.c
186

Probably worth calling out this cleanup specifically in the commit message

This revision is now accepted and ready to land.Jul 28 2025, 2:58 PM
This revision was automatically updated to reflect the committed changes.