Page MenuHomeFreeBSD

comsat: Don't read arbitrary files
ClosedPublic

Authored by des on Jul 27 2025, 7:48 PM.
Tags
None
Referenced Files
F175702679: D51580.id159250.diff
Mon, Oct 12, 3:36 PM
F175644081: D51580.diff
Mon, Oct 12, 6:14 AM
Unknown Object (File)
Sat, Oct 3, 6:48 PM
Unknown Object (File)
Fri, Oct 2, 1:58 PM
Unknown Object (File)
Sat, Sep 26, 8:44 PM
Unknown Object (File)
Thu, Sep 24, 6:38 AM
Unknown Object (File)
Tue, Sep 22, 7:04 AM
Unknown Object (File)
Sep 10 2026, 7:13 PM
Subscribers

Details

Summary

When processing a notification, instead of accepting any file name
that doesn't begin with a slash, accept only file names that don't
contain any slashes at all. This makes it possible to notify a
user about a mailbox that doesn't bear their name, as long as they
are permitted to read it, but prevents comsat from reading files
outside the mail spool.

PR: 270404
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jul 27 2025, 7:48 PM

Sorry, just realized this is incomplete. Will update in a bit.

Maybe we want to just discard a notification with a / in it rather than falling back to name (but I'm fine either way)

libexec/comsat/comsat.c
186

Probably worth calling out this cleanup specifically in the commit message

This revision is now accepted and ready to land.Jul 28 2025, 2:58 PM
This revision was automatically updated to reflect the committed changes.