Page MenuHomeFreeBSD

comsat: Don't read arbitrary files
ClosedPublic

Authored by des on Jul 27 2025, 7:48 PM.
Tags
None
Referenced Files
F144420181: D51580.id159252.diff
Sun, Feb 8, 8:37 AM
F144339588: D51580.id159250.diff
Sat, Feb 7, 10:34 PM
F144300405: D51580.id159331.diff
Sat, Feb 7, 5:39 PM
Unknown Object (File)
Sat, Jan 31, 6:37 AM
Unknown Object (File)
Wed, Jan 28, 2:13 AM
Unknown Object (File)
Sun, Jan 25, 11:46 PM
Unknown Object (File)
Fri, Jan 16, 9:45 AM
Unknown Object (File)
Dec 11 2025, 1:04 PM
Subscribers

Details

Summary

When processing a notification, instead of accepting any file name
that doesn't begin with a slash, accept only file names that don't
contain any slashes at all. This makes it possible to notify a
user about a mailbox that doesn't bear their name, as long as they
are permitted to read it, but prevents comsat from reading files
outside the mail spool.

PR: 270404
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jul 27 2025, 7:48 PM

Sorry, just realized this is incomplete. Will update in a bit.

Maybe we want to just discard a notification with a / in it rather than falling back to name (but I'm fine either way)

libexec/comsat/comsat.c
186

Probably worth calling out this cleanup specifically in the commit message

This revision is now accepted and ready to land.Jul 28 2025, 2:58 PM
This revision was automatically updated to reflect the committed changes.