Page MenuHomeFreeBSD
Differential D51357

libbegemot: improve tracing prints
ClosedPublic
Actions

Authored by glebius on Jul 16 2025, 6:07 PM.
Tags
None
Referenced Files
F164706323: D51357.id158628.diff
Mon, Aug 3, 6:56 AM
F164686011: D51357.id158680.diff
Mon, Aug 3, 4:24 AM
Unknown Object (File)
Sun, Aug 2, 1:25 AM
Unknown Object (File)
Wed, Jul 29, 7:27 AM
Unknown Object (File)
Sun, Jul 26, 7:01 PM
Unknown Object (File)
Sun, Jul 26, 11:47 AM
Unknown Object (File)
Sat, Jul 25, 8:57 PM
Unknown Object (File)
Mon, Jul 20, 10:02 PM
View All Files
Subscribers
imp

Details

Reviewers
harti
Commits
rG2181568715e8: libbegemot: improve tracing prints
Summary

Add newlines. Use func instead of hardcoded name (fixes one case).
While here, wrap lines according to style(9).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Jul 16 2025, 6:07 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 16 2025, 6:07 PM
glebius requested review of this revision.Jul 16 2025, 6:07 PM
Harbormaster completed remote builds in B65495: Diff 158628.Jul 16 2025, 6:07 PM
glebius added a parent revision: D51356: bsnmpd: in debugging mode (-d) use default library print/error functions.Jul 16 2025, 6:07 PM
glebius added a child revision: D51358: bsnmpd: use C99 initializers for transport definitions.
harti requested changes to this revision.Jul 17 2025, 10:00 AM

I think the line wrapping in line 289 is still not correct. Otherwise it looks fine.

This revision now requires changes to proceed.Jul 17 2025, 10:00 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Jul 17 2025, 4:03 PM
Closed by commit rG2181568715e8: libbegemot: improve tracing prints (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG2181568715e8: libbegemot: improve tracing prints.

Revision Contents
Changeset List

PathSize
contrib/
libbegemot/
22 lines

Diff 158680

View Options

contrib/libbegemot/rpoll.c

Loading...