Page MenuHomeFreeBSD
Differential D51325

gpiobus: plug IRQ leaks
ClosedPublic
Actions

Authored by vexeduxr on Jul 15 2025, 11:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 3:49 PM
Unknown Object (File)
Sat, Oct 11, 7:19 AM
Unknown Object (File)
Sat, Oct 11, 7:19 AM
Unknown Object (File)
Sat, Oct 11, 12:02 AM
Unknown Object (File)
Wed, Oct 8, 1:12 AM
Unknown Object (File)
Wed, Sep 24, 1:03 PM
Unknown Object (File)
Sep 14 2025, 5:12 AM
Unknown Object (File)
Sep 13 2025, 10:20 AM
View All 32 Files
Subscribers
imp
loos

Details

Reviewers
mmel
andrew
imp
Commits
rGcc86794b0319: gpiobus: plug IRQ leaks
Summary

Unmap the IRQ instead of just freeing the map data in the case of an
error. Also don't overwrite the resource's virtual address since the
copy of the map data made by intr_activate_irq is stored there.

Implement gpiobus_release_resource so it can unmap IRQs mapped by
gpio_alloc_intr_resource.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vexeduxr created this revision.Jul 15 2025, 11:11 AM
Herald added subscribers: loos, imp. · View Herald TranscriptJul 15 2025, 11:11 AM
vexeduxr requested review of this revision.Jul 15 2025, 11:11 AM
imp accepted this revision.Jul 15 2025, 5:45 PM
This revision is now accepted and ready to land.Jul 15 2025, 5:45 PM
This revision was landed with ongoing or failed builds.Jul 17 2025, 12:48 AM
Closed by commit rGcc86794b0319: gpiobus: plug IRQ leaks (authored by vexeduxr). · Explain Why
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rGcc86794b0319: gpiobus: plug IRQ leaks.

Revision Contents
Changeset List

PathSize
sys/
dev/
gpio/
24 lines

Diff 158646

View Options

sys/dev/gpio/gpiobus.c

Loading...