kyua: Make "test" command actually report about workdir cleanup issues

[igoro]

Summary

MFC after: 1 month

[ngie]

What was the behavior prior to this change?

[igoro]

In D51136#1170613, @ngie wrote:

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

[ngie]

In D51136#1170880, @igoro wrote:

In D51136#1170613, @ngie wrote:

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

Will this cause false positives with cleanup failures?

[igoro]

In D51136#1196294, @ngie wrote:

In D51136#1170880, @igoro wrote:

In D51136#1170613, @ngie wrote:

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

Will this cause false positives with cleanup failures?

No, they are not expected as this patch was intended to be pushed only after the fix of the cleanup logic which is there already: https://cgit.freebsd.org/src/commit/?id=9bf14f2a475e221c48488984dc5a02a4608bb877

[ngie]

In D51136#1196756, @igoro wrote:

No, they are not expected as this patch was intended to be pushed only after the fix of the cleanup logic which is there already: https://cgit.freebsd.org/src/commit/?id=9bf14f2a475e221c48488984dc5a02a4608bb877

Ok.