MFC after: 1 month
Details
Details
- Reviewers
ngie - Group Reviewers
tests - Commits
- rG21716b6c3ed6: kyua: Make "test" command actually report about workdir cleanup issues
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.
Comment Actions
No, they are not expected as this patch was intended to be pushed only after the fix of the cleanup logic which is there already: https://cgit.freebsd.org/src/commit/?id=9bf14f2a475e221c48488984dc5a02a4608bb877