Page MenuHomeFreeBSD

kyua: Make "test" command actually report about workdir cleanup issues
ClosedPublic

Authored by igoro on Jul 2 2025, 9:56 PM.
Tags
None
Referenced Files
F132111947: D51136.diff
Mon, Oct 13, 7:56 PM
Unknown Object (File)
Fri, Oct 10, 12:59 AM
Unknown Object (File)
Sat, Sep 27, 5:38 PM
Unknown Object (File)
Tue, Sep 23, 7:41 PM
Unknown Object (File)
Mon, Sep 15, 11:15 AM
Unknown Object (File)
Mon, Sep 15, 7:06 AM
Unknown Object (File)
Sep 13 2025, 7:26 AM
Unknown Object (File)
Sep 8 2025, 12:08 PM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

igoro requested review of this revision.Jul 2 2025, 9:56 PM

What was the behavior prior to this change?

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

Will this cause false positives with cleanup failures?

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

Will this cause false positives with cleanup failures?

No, they are not expected as this patch was intended to be pushed only after the fix of the cleanup logic which is there already: https://cgit.freebsd.org/src/commit/?id=9bf14f2a475e221c48488984dc5a02a4608bb877

No, they are not expected as this patch was intended to be pushed only after the fix of the cleanup logic which is there already: https://cgit.freebsd.org/src/commit/?id=9bf14f2a475e221c48488984dc5a02a4608bb877

Ok.

This revision is now accepted and ready to land.Sep 6 2025, 8:08 PM