Page MenuHomeFreeBSD
Differential D51136

kyua: Make "test" command actually report about workdir cleanup issues
ClosedPublic
Actions

Authored by igoro on Jul 2 2025, 9:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 10:42 PM
Unknown Object (File)
Thu, Oct 16, 8:59 AM
Unknown Object (File)
Thu, Oct 16, 8:59 AM
Unknown Object (File)
Thu, Oct 16, 8:59 AM
Unknown Object (File)
Wed, Oct 15, 9:20 PM
Unknown Object (File)
Mon, Oct 13, 7:56 PM
Unknown Object (File)
Fri, Oct 10, 12:59 AM
Unknown Object (File)
Sat, Sep 27, 5:38 PM
View All 20 Files
Subscribers
imp

Details

Reviewers
ngie
Group Reviewers
tests
Commits
rG21716b6c3ed6: kyua: Make "test" command actually report about workdir cleanup issues
Summary

MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

igoro created this revision.Jul 2 2025, 9:56 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 2 2025, 9:56 PM
igoro requested review of this revision.Jul 2 2025, 9:56 PM
Harbormaster completed remote builds in B65184: Diff 157862.Jul 2 2025, 9:56 PM
igoro added reviewers: ngie, tests.Jul 2 2025, 9:56 PM
ngie added a comment.Jul 12 2025, 2:55 AM

What was the behavior prior to this change?

igoro added a comment.Jul 12 2025, 5:42 PM
In D51136#1170613, @ngie wrote:

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

ngie added a comment.Sep 4 2025, 10:37 PM
In D51136#1170880, @igoro wrote:
In D51136#1170613, @ngie wrote:

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

Will this cause false positives with cleanup failures?

igoro added a comment.Sep 5 2025, 11:56 PM
In D51136#1196294, @ngie wrote:
In D51136#1170880, @igoro wrote:
In D51136#1170613, @ngie wrote:

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

Will this cause false positives with cleanup failures?

No, they are not expected as this patch was intended to be pushed only after the fix of the cleanup logic which is there already: https://cgit.freebsd.org/src/commit/?id=9bf14f2a475e221c48488984dc5a02a4608bb877

ngie accepted this revision.Sep 6 2025, 8:08 PM
In D51136#1196756, @igoro wrote:

No, they are not expected as this patch was intended to be pushed only after the fix of the cleanup logic which is there already: https://cgit.freebsd.org/src/commit/?id=9bf14f2a475e221c48488984dc5a02a4608bb877

Ok.

This revision is now accepted and ready to land.Sep 6 2025, 8:08 PM
Closed by commit rG21716b6c3ed6: kyua: Make "test" command actually report about workdir cleanup issues (authored by igoro). · Explain WhySat, Oct 11, 1:17 PM
This revision was automatically updated to reflect the committed changes.
igoro added a commit: rG21716b6c3ed6: kyua: Make "test" command actually report about workdir cleanup issues.

Revision Contents
Changeset List

PathSize
contrib/
kyua/
drivers/
2 lines

Diff 164017

View Options

contrib/kyua/drivers/run_tests.cpp

Loading...