linuxkpi: Remove incorrect + 1 from HWEIGHT* macros
ClosedPublic
Actions

Authored by emaste on Jun 24 2025, 1:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 7, 5:08 AM

	Unknown Object (File)
	Wed, Nov 26, 10:53 PM

	Unknown Object (File)
	Nov 2 2025, 11:47 PM

	Unknown Object (File)
	Nov 2 2025, 11:47 PM

	Unknown Object (File)
	Nov 2 2025, 11:45 PM

	Unknown Object (File)
	Nov 2 2025, 11:43 PM

	Unknown Object (File)
	Oct 31 2025, 10:49 AM

	Unknown Object (File)
	Oct 26 2025, 3:15 AM

View All 39 Files

Subscribers

imp

Details

Reviewers

Group Reviewers

linuxkpi

Commits

rGb84dd938c913: linuxkpi: Remove incorrect + 1 from HWEIGHT* macros
rGcdbff1b29996: linuxkpi: Remove incorrect + 1 from HWEIGHT* macros

Summary

On Linux these are equivalent to hweight* for known-constant arguments.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jun 24 2025, 1:39 PM

emaste created this revision.

emaste mentioned this in D50995: linuxkpi: Use `__builtin_popcountg()` instead of `bitcount*()`.

bz accepted this revision.Jun 24 2025, 10:05 PM

This revision is now accepted and ready to land.Jun 24 2025, 10:05 PM

Closed by commit rGcdbff1b29996: linuxkpi: Remove incorrect + 1 from HWEIGHT* macros (authored by emaste). · Explain WhyJun 24 2025, 10:43 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGcdbff1b29996: linuxkpi: Remove incorrect + 1 from HWEIGHT* macros.

Herald added a subscriber: imp. · View Herald TranscriptJun 24 2025, 10:43 PM

emaste added a commit: rGb84dd938c913: linuxkpi: Remove incorrect + 1 from HWEIGHT* macros.Jul 22 2025, 4:03 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

bitops.h

8 lines

Diff 157552

View Options

sys/compat/linuxkpi/common/include/linux/bitops.h

linuxkpi: Remove incorrect + 1 from HWEIGHT* macrosClosedPublicActions