Page MenuHomeFreeBSD
Differential D50967

libtpool/tests: Fix a flaky test
ClosedPublic
Actions

Authored by markj on Jun 21 2025, 6:32 PM.
Tags
None
Referenced Files
F144355339: D50967.id157411.diff
Sun, Feb 8, 12:35 AM
Unknown Object (File)
Sat, Feb 7, 4:07 PM
Unknown Object (File)
Sun, Feb 1, 11:16 AM
Unknown Object (File)
Fri, Jan 30, 4:42 PM
Unknown Object (File)
Dec 29 2025, 10:39 AM
Unknown Object (File)
Dec 8 2025, 5:10 PM
Unknown Object (File)
Dec 2 2025, 5:15 PM
Unknown Object (File)
Dec 2 2025, 4:00 AM
View All 42 Files
Subscribers
imp

Details

Reviewers
asomers
Commits
rG7b26124ae106: libtpool/tests: Fix a flaky test
Summary

I occasionally see failures due to pthread_barrier_wait() not returning
0. There is another possible non-error return value, so allow that too.
While here, check the result in tp_delay() as well.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jun 21 2025, 6:32 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 21 2025, 6:32 PM
markj requested review of this revision.Jun 21 2025, 6:32 PM
Harbormaster completed remote builds in B65011: Diff 157411.Jun 21 2025, 6:32 PM
markj added inline comments.Jun 21 2025, 6:33 PM
cddl/lib/libtpool/tests/libtpool_test.c
1

@asomers this file is missing a license header. Could you please add one?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2025, 5:17 PM
Closed by commit rG7b26124ae106: libtpool/tests: Fix a flaky test (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG7b26124ae106: libtpool/tests: Fix a flaky test.

Revision Contents
Changeset List

PathSize
cddl/
lib/
libtpool/
tests/
10 lines

Diff 157608

View Options

cddl/lib/libtpool/tests/libtpool_test.c

Loading...