nvme.ko: Don't include nvme_util.c
ClosedPublic
Actions

Authored by jhb on Jun 5 2025, 8:59 PM.

Tags

None

Referenced Files

	F172701500: D50705.id157121.diff
	Sun, Sep 20, 8:53 AM

	F172701463: D50705.id156590.diff
	Sun, Sep 20, 8:52 AM

	F172701220: D50705.diff
	Sun, Sep 20, 8:49 AM

	Unknown Object (File)
	Wed, Sep 16, 10:19 AM

	Unknown Object (File)
	Mon, Sep 7, 5:18 AM

	Unknown Object (File)
	Mon, Sep 7, 5:18 AM

	Unknown Object (File)
	Mon, Sep 7, 5:18 AM

	Unknown Object (File)
	Mon, Sep 7, 1:13 AM

View All 100 Files

Subscribers

dab

Details

Reviewers

imp

Commits

rG45165aab2d22: nvme.ko: Don't include nvme_util.c

Summary

This file is already included in cam.ko which is nvme.ko depends on
unconditionally.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jun 5 2025, 8:59 PM

Herald added a subscriber: dab. · View Herald TranscriptJun 5 2025, 8:59 PM

jhb requested review of this revision.Jun 5 2025, 8:59 PM

Harbormaster completed remote builds in B64664: Diff 156590.Jun 5 2025, 8:59 PM

I've tested this with numerous kernels combinations:

kernel without CAM but with nvme + nvd
kernel without nvme (MINIMAL was too big) but with CAM, nvme.ko can be kldloaded and works
kernel without CAM or nvme, nvme.ko can be kldloaded and pulls in cam.ko as an automatic dependency and works

imp accepted this revision.Jun 5 2025, 9:34 PM

This revision is now accepted and ready to land.Jun 5 2025, 9:34 PM

Closed by commit rG45165aab2d22: nvme.ko: Don't include nvme_util.c (authored by jhb). · Explain WhyJun 16 2025, 5:57 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG45165aab2d22: nvme.ko: Don't include nvme_util.c.

Revision Contents
Changeset List

Path

Size

sys/

modules/

nvme/

Makefile

1 line

Diff 157121

View Options

nvme.ko: Don't include nvme_util.cClosedPublicActions