Convert the A20 and A10 to plaform.

[manu_bidouilliste.com]

Summary

Add allwinner_soc_type and allwinner_soc_family function that return the current SoC type and family based on what the attach machdep function set.

Add include files that contain all the Allwinner Soc type and family defines.

Use ARM_INTRNG and generic_timer for A20 SoC a10-timer is now only used on a10 SoC.

Test Plan

Apply patch and compile kernel for A20 or one of the A10 based platform (CUBIEBOARD for example).

[andrew]

sys/arm/allwinner/allwinner_machdep.c

141–142 ↗

(On Diff #12656)

u_int
allwinner_soc_type(void)
{

sys/arm/allwinner/allwinner_machdep.h

5 ↗

(On Diff #12656)

Is this correct?

31 ↗

(On Diff #12656)

Should be

#ifndef _ALLWINNER_MACHDEP_H_
#define<tab>_ALLWINNER_MACHDEP_H_

33 ↗

(On Diff #12656)

All .c files should have included this before including this file

sys/arm/allwinner/timer.c

152–153 ↗

(On Diff #12656)

Have you hit this? We would expect the devicetree to be correct for the hardware.

[manu_bidouilliste.com]

Add answer to inline comments

sys/arm/allwinner/allwinner_machdep.h

5 ↗

(On Diff #12656)

Yes this is the original licence from a10_machdep.c

sys/arm/allwinner/timer.c

152–153 ↗

(On Diff #12656)

Yes, upstream a20 DTS also have the sun4i-a10-timer node

[manu_bidouilliste.com]

Fix style(9).
Sorry wrong cherry-pick ...

[andrew]

sys/arm/allwinner/allwinner_machdep.h

5 ↗

(On Diff #12657)

I don't see anything in this file that would require us to keep this notice, it looks like you've written everything other than the standard license.

sys/arm/allwinner/timer.c

152–153 ↗

(On Diff #12657)

Ok, move this change to the update fdt review as it's also includes a compatibility string change.

[manu_bidouilliste.com]

Remove fdt compatible prop change.

[andrew]

sys/arm/conf/A20

62 ↗

(On Diff #12659)

I think this also depends on the dts change. If so move it to that change & move timer.c back to files.allwinner

[manu_bidouilliste.com]

sys/arm/conf/A20

62 ↗

(On Diff #12659)

And what about gic and ARM_INTRNG ?
Should I also move them to the fdt change ? Or do another review that handle timer and gic ?

[andrew]

sys/arm/conf/A20

62 ↗

(On Diff #12659)

If generic_timer relies on a change in the dts move it to the fdt change.

What gic change do you mean? The only related changes I see are to enable ARM_INTRNG. I don't see how this would be an issue.

[manu_bidouilliste.com]

sys/arm/conf/A20

62 ↗

(On Diff #12659)

Yes you're right, I thought gic wasn't include in the original A20 file ... it's been a while.
For generic_timer is doesn't make sense right now are the our custom dts doesn't include the node.

[manu_bidouilliste.com]

Remove generic_timer for now as our custom DTS doesn't include the node.

[manu_bidouilliste.com]

Move timer.c to files.allwinner since A20 is still using it.