rtwn: do not start vap when initialization fails
ClosedPublic
Actions

Authored by avos on Jan 24 2016, 7:23 PM.

Details

Reviewers

kevlo
adrian

Commits

rS294842: rtwn: do not start vap when initialization fails

Summary

Start vap(s) (via ieee80211_start_all()) only when initialization succeeds; stop the first vap otherwise (via ieee80211_stop());
Do not try to stop a device multiple times (move (sc->sc_flags & RTWN_RUNNING) check to urtwn_stop_locked()).

Test Plan

untested, compilable

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 12655.Jan 24 2016, 7:23 PM

avos retitled this revision from to rtwn: do not start vap when initialization fails.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 24 2016, 7:23 PM

avos added a parent revision: D5057: rtwn: use ieee80211_restart_all() for device reset.Jan 24 2016, 7:24 PM

please find someone to test these and then I'll OK them

garga added a subscriber: garga.Jan 25 2016, 1:46 PM

Works for me. Tested on amd64 with RTL8188CE.

This revision is now accepted and ready to land.Jan 26 2016, 3:14 AM

two testers, positive reviews, good!

Closed by commit rS294842: rtwn: do not start vap when initialization fails (authored by avos). · Explain WhyJan 26 2016, 4:51 PM

This revision was automatically updated to reflect the committed changes.

avos added inline comments.Jan 26 2016, 4:53 PM

head/sys/dev/rtwn/if_rtwn.c
3371	An erroneous RTWN_UNLOCK(sc) was removed from here (left from previous version)

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

rtwn/

if_rtwn.c

47 lines

Diff 12729

View Options

head/sys/dev/rtwn/if_rtwn.c

rtwn: do not start vap when initialization failsClosedPublicActions