Page MenuHomeFreeBSD

Drop now unneeded ${PORTSDIR}
ClosedPublic

Authored by bapt on Jan 24 2016, 12:46 PM.

Details

Summary

Before 2016Q1 we have removed the necessity of specifying ${PORTSDIR}
in dependency lines.

Tested with portmaster, portupgrade and synth and poudriere (bulk -an)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bapt retitled this revision from to Drop now unneeded ${PORTSIDR}.Jan 24 2016, 12:46 PM
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.
bapt updated this revision to Diff 12633.
antoine requested changes to this revision.
antoine added a subscriber: antoine.

The bsd.databases.mk changes look unrelated and premature

This revision now requires changes to proceed.Jan 24 2016, 12:56 PM
bapt edited edge metadata.Jan 24 2016, 12:59 PM
bapt updated this revision to Diff 12634.

backout extra changes from bsd.databases.mk

antoine added inline comments.Jan 24 2016, 1:37 PM
Mk/bsd.port.mk
1862 ↗(On Diff #12634)

This change too

bapt edited edge metadata.Jan 24 2016, 2:32 PM
bapt updated this revision to Diff 12638.

Backout another change that should not have crept in

antoine edited edge metadata.Jan 27 2016, 8:01 PM
antoine requested changes to this revision.

There is a problem with _DEPEND_SPECIALS : ${PORTSDIR} may not be prepended and fetch-specials will fail to for dir in ${_DEPEND_SPECIALS}; ... cd $$dir; ${MAKE} fetch); ...

This revision now requires changes to proceed.Jan 27 2016, 8:01 PM
bapt added a comment.Jan 28 2016, 12:39 AM

Nice catch! I will that one and we will wait for another Q before committing that patch

bapt edited edge metadata.Mar 23 2016, 12:43 PM
bapt updated this revision to Diff 14545.

refresh

mat retitled this revision from Drop now unneeded ${PORTSIDR} to Drop now unneeded ${PORTSDIR}.Mar 23 2016, 12:55 PM
mat edited edge metadata.
This revision was automatically updated to reflect the committed changes.