Remove old generated unwind.h when using LLVM libunwind
ClosedPublic
Actions

Authored by emaste on Jan 21 2016, 3:05 PM.

Details

Reviewers

imp
bdrewery

Commits

rS294542: Remove old generated unwind.h when using LLVM libunwind

Summary

When not using LLVM libunwind, unwind.h is a generated header and a stale copy may remain in the OBJDIR after enabling LLVM libunwind. Explicitly remove it.

Reported by: bz

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 12554.Jan 21 2016, 3:05 PM

emaste retitled this revision from to Remove old generated unwind.h when using LLVM libunwind.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: bdrewery.

emaste added a reviewer: imp.Jan 21 2016, 9:29 PM

bdrewery added inline comments.Jan 21 2016, 9:43 PM

gnu/lib/libgcc/Makefile
200 ↗	(On Diff #12554)	I think either an exists() condition or @ should be used here to hide it. We don't need to see this rm every time we build.

Hide the command with @

bdrewery accepted this revision.Jan 21 2016, 9:52 PM

bdrewery edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2016, 9:52 PM

Closed by commit rS294542: Remove old generated unwind.h when using LLVM libunwind (authored by emaste). · Explain WhyJan 22 2016, 2:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

gnu/

lib/

libgcc/

Makefile

7 lines

Diff 12580

View Options

head/gnu/lib/libgcc/Makefile

Remove old generated unwind.h when using LLVM libunwindClosedPublicActions