mtw(4) Cleanup. No functional changes
AcceptedPublic
Actions

Authored by jsm on May 5 2025, 7:42 PM.

Tags

Referenced Files

	Unknown Object (File)
	Mon, Jun 23, 10:10 AM

	Unknown Object (File)
	Fri, Jun 20, 9:07 PM

	Unknown Object (File)
	Tue, Jun 3, 9:57 PM

	Unknown Object (File)
	Sun, Jun 1, 10:23 AM

	Unknown Object (File)
	Sat, May 31, 12:18 PM

	Unknown Object (File)
	Mon, May 26, 11:45 AM

	Unknown Object (File)
	May 24 2025, 4:12 PM

	Unknown Object (File)
	May 23 2025, 4:10 PM

Subscribers

imp

Details

Reviewers

adrian
waddlesplash_gmail.com
ziaee

Group Reviewers

wireless

Summary

mtw(4) Cleanup. No functional changes intended.

Only enable the hw.usb.mtw.debug sysctl when USB_DEBUG is defined.

Fixed small error from below usbd_transfer_start -> usbd_transfer_submit,
and added call to mtw_write_ivb

Obtained from: https://github.com/freebsd/freebsd-src/compare/main...waddlesplash:freebsd-src:mtw

Test Plan

local testing on current amd64, works also on RPI4 (tested on 14.1)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jsm created this revision.May 5 2025, 7:42 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 5 2025, 7:42 PM

jsm requested review of this revision.May 5 2025, 7:42 PM

in general +1, but why put debugging behind USB_DEBUG ? Doesn't USB_DEBUG pull in a bunch of other stuff?

guard the debug sysctl by MTW_DEBUG, which is defined if USB_DEBUG is defined, like if_run does it..

adrian accepted this revision.May 7 2025, 2:47 AM

adrian added inline comments.

sys/dev/usb/wlan/if_mtwvar.h
248	blank line!

This revision is now accepted and ready to land.May 7 2025, 2:47 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

wlan/

if_mtw.c

350 lines

if_mtwvar.h

224 lines

Diff 154986

View Options

sys/dev/usb/wlan/if_mtw.c